third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js - Issue 2198443004: [DevTools] Fix location.script().sourceURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

Issue 2198443004: [DevTools] Fix location.script().sourceURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js ('k') | third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

index 049d8acafdcfbf1b0f06669ffd6b14a5571fbdc5..ab377c846aa777dec78ebf6877ad489f397e064b 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js

@@ -110,7 +110,10 @@ WebInspector.CompilerScriptMapping.prototype = {

var entry = sourceMap.findEntry(lineNumber, columnNumber);

if (!entry || !entry.sourceURL)

return null;

- var uiSourceCode = this._networkMapping.uiSourceCodeForScriptURL(/** @type {string} */ (entry.sourceURL), rawLocation.script());

+ var script = rawLocation.script();

+ if (!script)

+ return null;

+ var uiSourceCode = this._networkMapping.uiSourceCodeForScriptURL(/** @type {string} */ (entry.sourceURL), script);

if (!uiSourceCode)

return null;

return uiSourceCode.uiLocation(/** @type {number} */ (entry.sourceLineNumber), /** @type {number} */ (entry.sourceColumnNumber));