third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js - Issue 2198443004: [DevTools] Fix location.script().sourceURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

Issue 2198443004: [DevTools] Fix location.script().sourceURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

index 4492c4e376abcdcc7f2feb0bbd524cb409dfe5ea..5f20ec60fd80ac254bd3bb9442d2d8dc2e2580b7 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js

@@ -85,9 +85,12 @@ WebInspector.BlackboxManager.prototype = {

isBlackboxedRawLocation: function(location)

{

- var positions = this._scriptPositions(location.script());

+ var script = location.script();

+ if (!script)

+ return false;

+ var positions = this._scriptPositions(script);

if (!positions)

- return this._isBlackboxedScript(location.script());

+ return this._isBlackboxedScript(script);

var index = positions.lowerBound(location, comparator);

return !!(index % 2);