Pass Notification into NotificationBlocker ShouldShow* methods

Pass Notification into NotificationBlocker ShouldShow* methods

Replace the NotifierId that is passed into
NotificationBlocker::ShowShowNotification and
NotificationBlocker::ShouldShowNotificationAsPopup with a Notification so that
the NotificationBlockers can consider data relating to the notification
(notably notification->delegate()). There are no behavior changes with this
commit.

BUG=481318
Committed: https://crrev.com/b34f499ab8308a03d4a11886109f28e7a3b360aa
Cr-Commit-Position: refs/heads/master@{#409595}

[bmalcolm, 2016-08-01 22:04:43]

The CQ bit was checked by bmalcolm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 22:05:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 22:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:05:01]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bmalcolm, 2016-08-01 22:11:56]

Description was changed from

==========
Pass Notification into NotificationBlocker ShouldShow* methods

Replace the NotifierId that is passed into
NotificationBlocker::ShowShowNotification and
NotificationBlocker::ShouldShowNotificationAsPopup with a Notification so that
the NotificationBlockers can consider data relating to the notification
(notably notification->delegate()). There are no behavior changes with this
commit.

BUG=481318
==========

to

==========
Pass Notification into NotificationBlocker ShouldShow* methods

Replace the NotifierId that is passed into
NotificationBlocker::ShowShowNotification and
NotificationBlocker::ShouldShowNotificationAsPopup with a Notification so that
the NotificationBlockers can consider data relating to the notification
(notably notification->delegate()). There are no behavior changes with this
commit.

BUG=481318
==========

[bmalcolm, 2016-08-01 22:11:56]

bmalcolm@chromium.org changed reviewers:
+ dewittj@chromium.org, sky@chromium.org

[bmalcolm, 2016-08-01 22:14:04]

Justin & I have previously discussed this approach. This is the first CL with
the goal of allowing the FullScreenNotificationBlocker to use the question of
whether the app currently displaying fullscreen content is the issuer of a
notification in its evaluation of whether to display a notification or not.

[bmalcolm, 2016-08-01 22:24:05]

Justin plans on looking at the whole cl, sky you really only need to look at the
ash components:

ash/first_run/desktop_cleaner.cc
 chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.cc
 chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.h

chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc

[dewittj, 2016-08-01 23:19:16]

lgtm, thanks!

[sky, 2016-08-02 16:23:37]

LGTM

[bmalcolm, 2016-08-02 17:34:07]

The CQ bit was checked by bmalcolm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 17:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 17:48:04]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bmalcolm, 2016-08-02 18:04:44]

The CQ bit was checked by bmalcolm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 18:05:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bmalcolm, 2016-08-02 18:07:53]

The CQ bit was unchecked by bmalcolm@chromium.org

[bmalcolm, 2016-08-02 18:07:54]

The CQ bit was checked by bmalcolm@chromium.org

[bmalcolm, 2016-08-02 18:07:54]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2198363002/#ps20001
(title: "Add missing .h file in ash tests")

[commit-bot: I haz the power, 2016-08-02 18:08:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 18:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 18:24:55]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bmalcolm, 2016-08-02 22:28:22]

The CQ bit was checked by bmalcolm@chromium.org

[bmalcolm, 2016-08-02 22:28:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2198363002/#ps40001
(title: "Ash build errors")

[bmalcolm, 2016-08-02 22:28:24]

The CQ bit was unchecked by bmalcolm@chromium.org

[bmalcolm, 2016-08-02 22:28:26]

The CQ bit was unchecked by bmalcolm@chromium.org

[bmalcolm, 2016-08-02 22:28:28]

The CQ bit was checked by bmalcolm@chromium.org

[bmalcolm, 2016-08-02 22:28:47]

The CQ bit was checked by bmalcolm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 22:28:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 23:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 23:14:59]

Dry run: This issue passed the CQ dry run.

[bmalcolm, 2016-08-02 23:16:11]

PTAL - for some reason the ash tests didn't run on my local machine so there
were compilation issues. I've added a header file and a using statement to a
couple of files.

[dewittj, 2016-08-03 19:01:44]

still lgtm, feel free to submit.

[bmalcolm, 2016-08-03 19:32:01]

The CQ bit was checked by bmalcolm@chromium.org

[bmalcolm, 2016-08-03 19:33:04]

The CQ bit was unchecked by bmalcolm@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:33:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bmalcolm, 2016-08-03 19:36:41]

The CQ bit was checked by bmalcolm@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:37:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 19:42:18]

Description was changed from

==========
Pass Notification into NotificationBlocker ShouldShow* methods

Replace the NotifierId that is passed into
NotificationBlocker::ShowShowNotification and
NotificationBlocker::ShouldShowNotificationAsPopup with a Notification so that
the NotificationBlockers can consider data relating to the notification
(notably notification->delegate()). There are no behavior changes with this
commit.

BUG=481318
==========

to

==========
Pass Notification into NotificationBlocker ShouldShow* methods

Replace the NotifierId that is passed into
NotificationBlocker::ShowShowNotification and
NotificationBlocker::ShouldShowNotificationAsPopup with a Notification so that
the NotificationBlockers can consider data relating to the notification
(notably notification->delegate()). There are no behavior changes with this
commit.

BUG=481318
==========

[commit-bot: I haz the power, 2016-08-03 19:42:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-03 19:44:45]

Description was changed from

==========
Pass Notification into NotificationBlocker ShouldShow* methods

Replace the NotifierId that is passed into
NotificationBlocker::ShowShowNotification and
NotificationBlocker::ShouldShowNotificationAsPopup with a Notification so that
the NotificationBlockers can consider data relating to the notification
(notably notification->delegate()). There are no behavior changes with this
commit.

BUG=481318
==========

to

==========
Pass Notification into NotificationBlocker ShouldShow* methods

Replace the NotifierId that is passed into
NotificationBlocker::ShowShowNotification and
NotificationBlocker::ShouldShowNotificationAsPopup with a Notification so that
the NotificationBlockers can consider data relating to the notification
(notably notification->delegate()). There are no behavior changes with this
commit.

BUG=481318

Committed: https://crrev.com/b34f499ab8308a03d4a11886109f28e7a3b360aa
Cr-Commit-Position: refs/heads/master@{#409595}
==========

[commit-bot: I haz the power, 2016-08-03 19:44:46]

Patchset 3 (id:??) landed as
https://crrev.com/b34f499ab8308a03d4a11886109f28e7a3b360aa
Cr-Commit-Position: refs/heads/master@{#409595}