chrome/browser/notifications/notification_interactive_uitest.cc - Issue 2198363002: Pass Notification into NotificationBlocker ShouldShow* methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_interactive_uitest.cc

Issue 2198363002: Pass Notification into NotificationBlocker ShouldShow* methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ash build errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc ('k') | chrome/browser/notifications/screen_lock_notification_blocker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_interactive_uitest.cc

diff --git a/chrome/browser/notifications/notification_interactive_uitest.cc b/chrome/browser/notifications/notification_interactive_uitest.cc

index 453fb59b79811c1e402537accbf0bade1104f6d5..1d6466b1ab816ff1167af580856889f0a0db8ab0 100644

--- a/chrome/browser/notifications/notification_interactive_uitest.cc

+++ b/chrome/browser/notifications/notification_interactive_uitest.cc

@@ -69,7 +69,7 @@ class ToggledNotificationBlocker : public message_center::NotificationBlocker {

// NotificationBlocker overrides:

bool ShouldShowNotificationAsPopup(

- const message_center::NotifierId& notifier_id) const override {

+ const message_center::Notification& notification) const override {

return notifications_enabled_;

}