chrome/browser/notifications/login_state_notification_blocker_chromeos.cc - Issue 2198363002: Pass Notification into NotificationBlocker ShouldShow* methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/login_state_notification_blocker_chromeos.cc

Issue 2198363002: Pass Notification into NotificationBlocker ShouldShow* methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Ash build errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/login_state_notification_blocker_chromeos.h ('k') | chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/login_state_notification_blocker_chromeos.cc

diff --git a/chrome/browser/notifications/login_state_notification_blocker_chromeos.cc b/chrome/browser/notifications/login_state_notification_blocker_chromeos.cc

index 1caad4b850247d9cc97c2cbd68f9434db2f4b218..6b74bf0359c3b3c347e005a2509a162d50db2211 100644

--- a/chrome/browser/notifications/login_state_notification_blocker_chromeos.cc

+++ b/chrome/browser/notifications/login_state_notification_blocker_chromeos.cc

@@ -46,8 +46,8 @@ LoginStateNotificationBlockerChromeOS::

}

bool LoginStateNotificationBlockerChromeOS::ShouldShowNotificationAsPopup(

- const message_center::NotifierId& notifier_id) const {

- if (ash::system_notifier::ShouldAlwaysShowPopups(notifier_id))

+ const message_center::Notification& notification) const {

+ if (ash::system_notifier::ShouldAlwaysShowPopups(notification.notifier_id()))

return true;

if (locked_)