Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: ui/message_center/notification_list.cc

Issue 2198363002: Pass Notification into NotificationBlocker ShouldShow* methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ash build errors Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/notification_blocker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/notification_list.cc
diff --git a/ui/message_center/notification_list.cc b/ui/message_center/notification_list.cc
index 0ac3b1cbb8b07d68ae42e5a5565bc5e8b11af0b1..9231602f8bbe399ac30f1ccfa642560f1e9af97b 100644
--- a/ui/message_center/notification_list.cc
+++ b/ui/message_center/notification_list.cc
@@ -26,7 +26,7 @@ bool ShouldShowNotificationAsPopup(
const Notification& notification,
const NotificationBlockers& blockers) {
for (size_t i = 0; i < blockers.size(); ++i) {
- if (!blockers[i]->ShouldShowNotificationAsPopup(notification.notifier_id()))
+ if (!blockers[i]->ShouldShowNotificationAsPopup(notification))
return false;
}
return true;
@@ -280,7 +280,7 @@ NotificationList::Notifications NotificationList::GetVisibleNotifications(
iter != notifications_.end(); ++iter) {
bool should_show = true;
for (size_t i = 0; i < blockers.size(); ++i) {
- if (!blockers[i]->ShouldShowNotification((*iter)->notifier_id())) {
+ if (!blockers[i]->ShouldShowNotification(**iter)) {
should_show = false;
break;
}
« no previous file with comments | « ui/message_center/notification_blocker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698