third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp - Issue 2196583002: Paint local background colors onto foreground layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

Issue 2196583002: Paint local background colors onto foreground layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only set PaintLayerPaintingRootBackgroundOntoForeground while painting root background instead of s… Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintLayer.h ('K') | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h » ('j') | third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

index 58a6e0af7fa78625423459c75e00e5de63f499e1..9179d01188ee60c535ecf09d7b3a985d47a7e021 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp

@@ -381,15 +381,21 @@ PaintLayerPainter::PaintResult PaintLayerPainter::paintLayerContents(GraphicsCon

scopedPaintChunkProperties.emplace(context.getPaintController(), m_paintLayer, properties);

}

- bool shouldPaintBackground = isPaintingCompositedBackground && shouldPaintContent && !selectionOnly;

+ bool shouldPaintBackgroundOntoForeground = paintFlags & PaintLayerPaintingCompositingScrollingPhase

+ && m_paintLayer.shouldPaintBackgroundOntoForeground();

+ bool shouldPaintBackground = shouldPaintContent && !selectionOnly

+ && (shouldPaintBackgroundOntoForeground || isPaintingCompositedBackground);

bool shouldPaintNegZOrderList = (isPaintingScrollingContent && isPaintingOverflowContents) || (!isPaintingScrollingContent && isPaintingCompositedBackground);

bool shouldPaintOwnContents = isPaintingCompositedForeground && shouldPaintContent;

bool shouldPaintNormalFlowAndPosZOrderLists = isPaintingCompositedForeground;

bool shouldPaintOverlayScrollbars = isPaintingOverlayScrollbars;

if (shouldPaintBackground) {

+ PaintLayerFlags localPaintFlags(paintFlags);

+ if (shouldPaintBackgroundOntoForeground)

+ localPaintFlags |= PaintLayerPaintingRootBackgroundOntoForeground;

paintBackgroundForFragments(layerFragments, context, paintingInfo.paintDirtyRect,

- localPaintingInfo, paintFlags);

+ localPaintingInfo, localPaintFlags);

}

if (shouldPaintNegZOrderList) {