third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h - Issue 2196583002: Paint local background colors onto foreground layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h

Issue 2196583002: Paint local background colors onto foreground layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only set PaintLayerPaintingRootBackgroundOntoForeground while painting root background instead of s… Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintLayer.h ('K') | « third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp ('k') | third_party/WebKit/Source/core/paint/TableRowPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h b/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h

index e3fca6881003c7498d85fd03f4ebe542dec1adf3..076cc97a91dc00b2022cb6eeb30308da9798dbed 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h

@@ -70,6 +70,7 @@ enum PaintLayerFlag {

PaintLayerPaintingSkipRootBackground = 1 << 11,

PaintLayerPaintingChildClippingMaskPhase = 1 << 12,

PaintLayerPaintingRenderingClipPathAsMask = 1 << 13,

+ PaintLayerPaintingRootBackgroundOntoForeground = 1 << 14,

chrishtr 2016/08/03 18:58:00 How about PaintLayerPaintingRootBackgroundOntoScro

flackr 2016/08/03 20:58:53 Sure, should I replace foreground elsewhere with s

PaintLayerPaintingCompositingAllPhases = (PaintLayerPaintingCompositingBackgroundPhase | PaintLayerPaintingCompositingForegroundPhase | PaintLayerPaintingCompositingMaskPhase)

};