third_party/WebKit/Source/core/paint/PaintLayer.cpp - Issue 2196583002: Paint local background colors onto foreground layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2196583002: Paint local background colors onto foreground layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only set PaintLayerPaintingRootBackgroundOntoForeground while painting root background instead of s… Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/PaintLayer.h ('K') | « third_party/WebKit/Source/core/paint/PaintLayer.h ('k') | third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

index a64558467ff54ca6604f5546f75b932f9197e19d..37ce0c0ef3eab401c88b761c951605325a0ca471 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp

@@ -2452,6 +2452,19 @@ bool PaintLayer::shouldBeSelfPaintingLayer() const

|| needsCompositedScrolling();

}

+bool PaintLayer::shouldPaintBackgroundOntoForeground() const

+ // TODO(flackr): Add support for painting locally attached background images. https://crbug.com/625882

+ const FillLayer& backgroundLayer = layoutObject()->style()->backgroundLayers();

+ return !isRootLayer()

+ && scrollsOverflow()

+ && !backgroundLayer.image()

+ && !backgroundLayer.next()

+ && (backgroundLayer.attachment() == LocalBackgroundAttachment

+ || backgroundLayer.clip() == PaddingFillBox)

+ && !stackingNode()->hasNegativeZOrderList();

void PaintLayer::updateSelfPaintingLayer()

{

bool isSelfPaintingLayer = shouldBeSelfPaintingLayer();