third_party/WebKit/Source/core/paint/PaintLayer.h - Issue 2196583002: Paint local background colors onto foreground layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2196583002: Paint local background colors onto foreground layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Only set PaintLayerPaintingRootBackgroundOntoForeground while painting root background instead of s… Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxPainter.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayerPaintingInfo.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayer.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h

index 469fe7891a25ab120649fccc0ca32b4ebda4c893..e4c00b03b1a34926e86add0d2f35fe037aa04bb3 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h

@@ -247,6 +247,8 @@ public:

PaintLayerReflectionInfo* reflectionInfo() { return m_rareData ? m_rareData->reflectionInfo.get() : nullptr; }

const PaintLayerReflectionInfo* reflectionInfo() const { return const_cast<PaintLayer*>(this)->reflectionInfo(); }

+ bool shouldPaintBackgroundOntoForeground() const;

chrishtr 2016/08/03 18:58:00 This needs a comment.

flackr 2016/08/03 20:58:53 Done.

const PaintLayer* root() const

{

const PaintLayer* curr = this;