Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2196533003: [api] Cleaning up: Replace NeanderArray with FixedArray implementation (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Cleaning up: Replace NeanderArray with FixedArray implementation BUG=chromium:630217 Committed: https://crrev.com/9aa4496278472612d5c39195d1fdcc3503f1e486 Cr-Commit-Position: refs/heads/master@{#38213}

Patch Set 1 #

Patch Set 2 : no understand c++ #

Patch Set 3 : rename to TemplateList to avoid name collision #

Patch Set 4 : fixing compilation issues #

Patch Set 5 : fixing wrong indexing #

Patch Set 6 : fixing message listener removal #

Patch Set 7 : mind the pointers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -140 lines) Patch
M src/api.h View 1 2 2 chunks +0 lines, -28 lines 0 comments Download
M src/api.cc View 1 2 3 4 5 6 3 chunks +10 lines, -51 lines 0 comments Download
M src/api-natives.cc View 1 2 3 6 chunks +35 lines, -35 lines 0 comments Download
M src/bootstrapper.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/contexts.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 3 1 chunk +1 line, -6 lines 0 comments Download
M src/messages.cc View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 4 chunks +18 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 4 chunks +28 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 3 chunks +25 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Camillo Bruni
ulan@ PTAL ze heap jochen@ PTAL at the rest
4 years, 4 months ago (2016-08-01 11:58:15 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-01 12:03:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2196533003/120001
4 years, 4 months ago (2016-08-01 14:26:17 UTC) #9
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 4 months ago (2016-08-01 14:28:13 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 14:28:48 UTC) #12
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/9aa4496278472612d5c39195d1fdcc3503f1e486
Cr-Commit-Position: refs/heads/master@{#38213}

Powered by Google App Engine
This is Rietveld 408576698