Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2195243003: [api] Remove NeanderObject (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@2016-07-29_api_remove_NeanderArray_2196533003
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Remove NeanderObject We no longer need NeanderObject, the only user left was the message listener machanism which could be replace by direct uses of FixedArrays. BUG=chromium:630217 Committed: https://crrev.com/7e5119045894eb47ebd008076593dfce5d47b492 Cr-Commit-Position: refs/heads/master@{#38249}

Patch Set 1 #

Patch Set 2 : fixing gcmole issue #

Patch Set 3 : fixing rebase issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -73 lines) Patch
M src/api.h View 2 chunks +0 lines, -41 lines 0 comments Download
M src/api.cc View 1 3 chunks +9 lines, -29 lines 0 comments Download
M src/messages.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-08-01 15:41:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-01 15:47:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195243003/1
4 years, 4 months ago (2016-08-02 11:09:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/10068) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-02 11:51:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195243003/40001
4 years, 4 months ago (2016-08-02 14:15:59 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-02 14:40:01 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 14:41:18 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7e5119045894eb47ebd008076593dfce5d47b492
Cr-Commit-Position: refs/heads/master@{#38249}

Powered by Google App Engine
This is Rietveld 408576698