Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: src/api.h

Issue 2196533003: [api] Cleaning up: Replace NeanderArray with FixedArray implementation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mind the pointers Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.h
diff --git a/src/api.h b/src/api.h
index a5c39ba698e214380fd2e78d29dfeafd896f8cd7..661ffe0f728954739ab487e8d656816ccf1aa6ab 100644
--- a/src/api.h
+++ b/src/api.h
@@ -43,30 +43,6 @@ class NeanderObject {
};
-// Utilities for working with neander-arrays, a simple extensible
-// array abstraction built on neander-objects.
-class NeanderArray {
- public:
- explicit NeanderArray(v8::internal::Isolate* isolate);
- explicit inline NeanderArray(v8::internal::Handle<v8::internal::Object> obj);
- inline v8::internal::Handle<v8::internal::JSObject> value() {
- return obj_.value();
- }
-
- void add(internal::Isolate* isolate,
- v8::internal::Handle<v8::internal::Object> value);
-
- int length();
-
- v8::internal::Object* get(int index);
- // Change the value at an index to undefined value. If the index is
- // out of bounds, the request is ignored. Returns the old value.
- void set(int index, v8::internal::Object* value);
- private:
- NeanderObject obj_;
-};
-
-
NeanderObject::NeanderObject(v8::internal::Handle<v8::internal::Object> obj)
: value_(v8::internal::Handle<v8::internal::JSObject>::cast(obj)) { }
@@ -76,10 +52,6 @@ NeanderObject::NeanderObject(v8::internal::Object* obj)
v8::internal::JSObject::cast(obj))) { }
-NeanderArray::NeanderArray(v8::internal::Handle<v8::internal::Object> obj)
- : obj_(obj) { }
-
-
v8::internal::Object* NeanderObject::get(int offset) {
DCHECK(value()->HasFastObjectElements());
return v8::internal::FixedArray::cast(value()->elements())->get(offset);
« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698