Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: src/messages.cc

Issue 2196533003: [api] Cleaning up: Replace NeanderArray with FixedArray implementation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mind the pointers Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.cc
diff --git a/src/messages.cc b/src/messages.cc
index ae99df29ddaa6ad912fb3367080a395d7ffe1b2c..316bdca8e971905f4c590650ede8f8ec0889335e 100644
--- a/src/messages.cc
+++ b/src/messages.cc
@@ -123,8 +123,9 @@ void MessageHandler::ReportMessage(Isolate* isolate, MessageLocation* loc,
v8::Local<v8::Message> api_message_obj = v8::Utils::MessageToLocal(message);
v8::Local<v8::Value> api_exception_obj = v8::Utils::ToLocal(exception);
- v8::NeanderArray global_listeners(isolate->factory()->message_listeners());
- int global_length = global_listeners.length();
+ Handle<TemplateList> global_listeners =
+ isolate->factory()->message_listeners();
+ int global_length = global_listeners->length();
if (global_length == 0) {
DefaultMessageReport(isolate, loc, message);
if (isolate->has_scheduled_exception()) {
@@ -133,8 +134,8 @@ void MessageHandler::ReportMessage(Isolate* isolate, MessageLocation* loc,
} else {
for (int i = 0; i < global_length; i++) {
HandleScope scope(isolate);
- if (global_listeners.get(i)->IsUndefined(isolate)) continue;
- v8::NeanderObject listener(JSObject::cast(global_listeners.get(i)));
+ if (global_listeners->get(i)->IsUndefined(isolate)) continue;
+ v8::NeanderObject listener(JSObject::cast(global_listeners->get(i)));
Handle<Foreign> callback_obj(Foreign::cast(listener.get(0)));
v8::MessageCallback callback =
FUNCTION_CAST<v8::MessageCallback>(callback_obj->foreign_address());
« no previous file with comments | « src/heap/heap.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698