Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2195743005:
Fix ineffective --disable-gpu-driver-bug-workarounds (Closed)
|
Created:
4 years, 4 months ago by Julien Isorce Samsung Modified:
4 years, 4 months ago CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix ineffective --disable-gpu-driver-bug-workarounds
It was hidden to the user since chrome://gpu was not showing
any workarounds, but they were still applied in the gpu process.
Also add a gpu test that sets
--disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing
and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND
in both browser and gpu processes.
BUG=359367
R=kbr@chromium.org, zmo@chromium.org
TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755
Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd
Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6
Committed: https://crrev.com/31f3d211396da3c7ca23684b6582554f0f6738b0
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#409197}
Cr-Original-Original-Commit-Position: refs/heads/master@{#412685}
Cr-Original-Commit-Position: refs/heads/master@{#412989}
Cr-Commit-Position: refs/heads/master@{#413411}
Patch Set 1 #Patch Set 2 : Rebase and use the testing workaround instead #Patch Set 3 : Rebase #
Total comments: 2
Patch Set 4 : Rebase and fixed 'Patch Set 2' #Patch Set 5 : Badly included an unrelated change in previous Patch Set #Patch Set 6 : Rebase #Patch Set 7 : Rebase and modify the test to record, restart and compare #
Total comments: 4
Patch Set 8 : Rebase and beautiffy the new test #Patch Set 9 : Also allow the new test to catch the bug in gpu_process_host.cc #
Total comments: 3
Patch Set 10 : Fix left over of some local testing #Patch Set 11 : Rebase #Patch Set 12 : Set a device id to make sure to not hit a black list entry #Patch Set 13 : record and re-apply disabled gl extensions to avoid known gpu driver crashes #
Messages
Total messages: 101 (68 generated)
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --force_discrete_gpu and verifies that the only active workaround is FORCE_DISCRETE_GPU in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --force_discrete_gpu and verifies that the only active workaround is FORCE_DISCRETE_GPU in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --force_discrete_gpu and verifies that the only active workaround is FORCE_DISCRETE_GPU in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/01 15:41:37, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Hi, please have a look. Thx.
LGTM https://codereview.chromium.org/2195743005/diff/40001/content/test/gpu/page_s... File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/2195743005/diff/40001/content/test/gpu/page_s... content/test/gpu/page_sets/gpu_process_tests.py:599: 'to only force_discrete_gpu workaround: %s != %s' % \ Should this be "to only use_gpu_driver_workaround_for_testing"?
Thx for the review. https://codereview.chromium.org/2195743005/diff/40001/content/test/gpu/page_s... File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/2195743005/diff/40001/content/test/gpu/page_s... content/test/gpu/page_sets/gpu_process_tests.py:599: 'to only force_discrete_gpu workaround: %s != %s' % \ On 2016/08/01 21:53:50, Ken Russell wrote: > Should this be "to only use_gpu_driver_workaround_for_testing"? Done, thx!
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2195743005/#ps100001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Cr-Commit-Position: refs/heads/master@{#409197} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Cr-Commit-Position: refs/heads/master@{#409197}
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2203713003/ by kbr@chromium.org. The reason for reverting is: New test causes assertion failures in the GPU process on Nexus 9 and possibly other devices. See https://bugs.chromium.org/p/chromium/issues/detail?id=359367#c3 . .
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Cr-Commit-Position: refs/heads/master@{#409197} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Cr-Commit-Position: refs/heads/master@{#409197} ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I Ken, in Patch Set 7 I did what you suggest in comment #8 here https://bugs.chromium.org/p/chromium/issues/detail?id=359367#c8 . To restart the browser I use the fact that it already restart it after each test. To transfer the recorded workarounds I just use the same shared state. Problem is that the test passes with and without the change in gpu_process_host.cc :) Which make senses but I realized it afterward.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2195743005/diff/120001/content/test/gpu/page_... File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/2195743005/diff/120001/content/test/gpu/page_... content/test/gpu/page_sets/gpu_process_tests.py:605: def Validate(self, tab, results): Does this test pass the first time through? If so, why does it? It doesn't look like use_gpu_driver_workaround_for_testing is set the first time through so it looks to me like the test should fail, unless it can detect that it should exit early. https://codereview.chromium.org/2195743005/diff/120001/content/test/gpu/page_... content/test/gpu/page_sets/gpu_process_tests.py:665: self.AddStory(OnlyOneWorkaroundPage(self, expectations)) If it works correctly to run the same test twice, the first time to gather the browser's driver bug workarounds and the second time to launch the browser with them, then please add a comment here indicating why the test's being run twice.
https://codereview.chromium.org/2195743005/diff/120001/content/test/gpu/page_... File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/2195743005/diff/120001/content/test/gpu/page_... content/test/gpu/page_sets/gpu_process_tests.py:605: def Validate(self, tab, results): On 2016/08/09 21:30:32, Ken Russell wrote: > Does this test pass the first time through? If so, why does it? It doesn't look > like use_gpu_driver_workaround_for_testing is set the first time through so it > looks to me like the test should fail, unless it can detect that it should exit > early. Yes. https://codereview.chromium.org/2195743005/diff/120001/content/test/gpu/page_... content/test/gpu/page_sets/gpu_process_tests.py:665: self.AddStory(OnlyOneWorkaroundPage(self, expectations)) On 2016/08/09 21:30:32, Ken Russell wrote: > If it works correctly to run the same test twice, the first time to gather the > browser's driver bug workarounds and the second time to launch the browser with > them, then please add a comment here indicating why the test's being run twice. In patch set 8, I merged the warmup test with existing test EqualBugWorkaroundsPage since they were doing the same thing essentially.
On 2016/08/09 15:24:35, Julien Isorce wrote: > Problem is that the test passes with and without the change in > gpu_process_host.cc :) Which make senses but I realized it afterward. But next step is to find a way to catch that bug so that if --disable-gpu-driver-bug-workarounds does not work then the test fails.
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM The new test looks fine though a little complicated. Please continue to think about how to simplify it. Thanks.
On 2016/08/15 23:35:54, Julien Isorce wrote: > On 2016/08/09 15:24:35, Julien Isorce wrote: > > Problem is that the test passes with and without the change in > > gpu_process_host.cc :) Which make senses but I realized it afterward. > > But next step is to find a way to catch that bug so that > if --disable-gpu-driver-bug-workarounds does not work then the test fails. Done in patch set 9. On 2016/08/16 01:42:50, Ken Russell wrote: > LGTM > > The new test looks fine though a little complicated. Please continue to think > about how to simplify it. Thanks. Thx for the review. I can try to use some class members to transfer the recorded workaround from on test to another instead of a shared state.
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2195743005/diff/160001/content/test/gpu/page_... File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/2195743005/diff/160001/content/test/gpu/page_... content/test/gpu/page_sets/gpu_process_tests.py:595: options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x10dee') This looks like a typo, and that it should be 0x10de. If that's true -- how did this pass the new test?
https://codereview.chromium.org/2195743005/diff/160001/content/test/gpu/page_... File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/2195743005/diff/160001/content/test/gpu/page_... content/test/gpu/page_sets/gpu_process_tests.py:595: options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x10dee') On 2016/08/17 06:52:22, Ken Russell wrote: > This looks like a typo, and that it should be 0x10de. If that's true -- how did > this pass the new test? Oh sorry it is a left over of some local testing. Locally I also changed the value in entry 5 in gpu_driver_bug_list_json.cc. The reason why it passes the CQ dry dun is that it does not trigger any additional workaround since it does not match any entry. But even though this bit is to trigger the bug in gpu_process_host.cc that this CL also fixes. So to make the test fail you need to remove the fix in gpu_process_host.cc and make it 0x10de. Then it will trigger the entry 5 and fails the test because it will be different than the recorded list. Of course this part is only useful on non nvidia hardware but I guess we can assume there will be always tests on other hardwares. Thx for catching that!. About simplifying the test using class attributes, what do you think ?
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2195743005/diff/160001/content/test/gpu/page_... File content/test/gpu/page_sets/gpu_process_tests.py (right): https://codereview.chromium.org/2195743005/diff/160001/content/test/gpu/page_... content/test/gpu/page_sets/gpu_process_tests.py:595: options.AppendExtraBrowserArgs('--gpu-testing-vendor-id=0x10dee') On 2016/08/17 07:49:13, Julien Isorce wrote: > On 2016/08/17 06:52:22, Ken Russell wrote: > > This looks like a typo, and that it should be 0x10de. If that's true -- how > did > > this pass the new test? > > Oh sorry it is a left over of some local testing. Locally I also changed the > value in entry 5 in gpu_driver_bug_list_json.cc. > The reason why it passes the CQ dry dun is that it does not trigger any > additional workaround since it does not match any entry. But even though this > bit is to trigger the bug in gpu_process_host.cc that this CL also fixes. So to > make the test fail you need to remove the fix in gpu_process_host.cc and make it > 0x10de. Then it will trigger the entry 5 and fails the test because it will be > different than the recorded list. > Of course this part is only useful on non nvidia hardware but I guess we can > assume there will be always tests on other hardwares. It's concerning to me that it would have been possible for that to slip in and not fail any test. Please give this more thought. > Thx for catching that!. About simplifying the test using class attributes, what > do you think ? Why don't you do that in a follow-on patch. This one has been dragging on for some time.
To be clear, LGTM again -- let's please get this in.
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2195743005/#ps200001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Cr-Commit-Position: refs/heads/master@{#409197} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Cr-Commit-Position: refs/heads/master@{#409197} ==========
Message was sent while issue was closed.
Committed patchset #11 (id:200001)
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Cr-Commit-Position: refs/heads/master@{#409197} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Cr-Original-Commit-Position: refs/heads/master@{#409197} Cr-Commit-Position: refs/heads/master@{#412685} ==========
Message was sent while issue was closed.
Patchset 11 (id:??) landed as https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Cr-Commit-Position: refs/heads/master@{#412685}
Message was sent while issue was closed.
A revert of this CL (patchset #11 id:200001) has been created in https://codereview.chromium.org/2253413002/ by j.isorce@samsung.com. The reason for reverting is: Cause failures on Nexus 9 GPU bot https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2....
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Cr-Original-Commit-Position: refs/heads/master@{#409197} Cr-Commit-Position: refs/heads/master@{#412685} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Cr-Original-Commit-Position: refs/heads/master@{#409197} Cr-Commit-Position: refs/heads/master@{#412685} ==========
On 2016/08/18 06:59:32, Julien Isorce wrote: > The reason for reverting is: Cause failures on Nexus 9 GPU bot > https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2.... Some how the gpu process stops or crashes: "process_crash_count : 1" From GpuProcessHost::Get // TODO(sievers): Revisit this behavior. It's not really a crash, but we also // want the fallback-to-sw behavior if we cannot initialize the GPU. host->RecordProcessCrash(); ( https://bugs.chromium.org/p/chromium/issues/detail?id=598400 ) I cannot see which black list entry it would hit here. In any case I have uploaded Patch Set 12 to help debugging.
On 2016/08/18 15:20:22, Julien Isorce wrote: > On 2016/08/18 06:59:32, Julien Isorce wrote: > > The reason for reverting is: Cause failures on Nexus 9 GPU bot > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2.... > > Some how the gpu process stops or crashes: "process_crash_count : 1" > > From GpuProcessHost::Get > // TODO(sievers): Revisit this behavior. It's not really a crash, but we also > // want the fallback-to-sw behavior if we cannot initialize the GPU. > host->RecordProcessCrash(); > ( https://bugs.chromium.org/p/chromium/issues/detail?id=598400 ) > > I cannot see which black list entry it would hit here. In any case > I have uploaded Patch Set 12 to help debugging. I am going to re-land it.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2195743005/#ps220001 (title: "Set a device id to make sure to not hit a black list entry")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Cr-Original-Commit-Position: refs/heads/master@{#409197} Cr-Commit-Position: refs/heads/master@{#412685} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Cr-Original-Commit-Position: refs/heads/master@{#409197} Cr-Commit-Position: refs/heads/master@{#412685} ==========
Message was sent while issue was closed.
Committed patchset #12 (id:220001)
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Cr-Original-Commit-Position: refs/heads/master@{#409197} Cr-Commit-Position: refs/heads/master@{#412685} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 Cr-Original-Original-Commit-Position: refs/heads/master@{#409197} Cr-Original-Commit-Position: refs/heads/master@{#412685} Cr-Commit-Position: refs/heads/master@{#412989} ==========
Message was sent while issue was closed.
Patchset 12 (id:??) landed as https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 Cr-Commit-Position: refs/heads/master@{#412989}
Message was sent while issue was closed.
A revert of this CL (patchset #12 id:220001) has been created in https://codereview.chromium.org/2257373002/ by j.isorce@samsung.com. The reason for reverting is: Still cause failures on Nexus 9 https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2... But this time I think I understand why. It could be because the test should also record the disabled extensions. To re-apply them manually when passing --disable-gpu-driver-bug-workarounds.
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 Cr-Original-Original-Commit-Position: refs/heads/master@{#409197} Cr-Original-Commit-Position: refs/heads/master@{#412685} Cr-Commit-Position: refs/heads/master@{#412989} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 Cr-Original-Original-Commit-Position: refs/heads/master@{#409197} Cr-Original-Commit-Position: refs/heads/master@{#412685} Cr-Commit-Position: refs/heads/master@{#412989} ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
On 2016/08/19 05:35:19, Julien Isorce wrote: > A revert of this CL (patchset #12 id:220001) has been created in > https://codereview.chromium.org/2257373002/ by mailto:j.isorce@samsung.com. > > The reason for reverting is: Still cause failures on Nexus 9 > https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2... > > But this time I think I understand why. It could be because the test should also > record the disabled extensions. To re-apply them manually when passing > --disable-gpu-driver-bug-workarounds. I uploaded Patch Set 13. The new test now also records the disabled gl extensions in addition to the gpu driver bug workarounds. Then the test re-apply them since --disable-gpu-driver-bug-workarounds disable both workarounds and extensions. So please have a look, thx. I believe that not disabling one of the following extensions was what causes the gl driver to crash on nexus 9: GL_EXT_disjoint_timer_query GL_NV_path_rendering EGL_KHR_wait_sync
On 2016/08/19 14:31:14, Julien Isorce wrote: > On 2016/08/19 05:35:19, Julien Isorce wrote: > > A revert of this CL (patchset #12 id:220001) has been created in > > https://codereview.chromium.org/2257373002/ by mailto:j.isorce@samsung.com. > > > > The reason for reverting is: Still cause failures on Nexus 9 > > > https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2... > > > > But this time I think I understand why. It could be because the test should > also > > record the disabled extensions. To re-apply them manually when passing > > --disable-gpu-driver-bug-workarounds. > > I uploaded Patch Set 13. The new test now also records the disabled gl > extensions in addition > to the gpu driver bug workarounds. Then the test re-apply them since > --disable-gpu-driver-bug-workarounds disable both workarounds and extensions. > So please have a look, thx. > > I believe that not disabling one of the following extensions was what causes > the gl driver to crash on nexus 9: > GL_EXT_disjoint_timer_query > GL_NV_path_rendering > EGL_KHR_wait_sync gpu_data_manager_impl_private.cc lgtm
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Good catch on the handling of the disabled extensions. Still LGTM
The CQ bit was checked by j.isorce@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 Cr-Original-Original-Commit-Position: refs/heads/master@{#409197} Cr-Original-Commit-Position: refs/heads/master@{#412685} Cr-Commit-Position: refs/heads/master@{#412989} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 Cr-Original-Original-Commit-Position: refs/heads/master@{#409197} Cr-Original-Commit-Position: refs/heads/master@{#412685} Cr-Commit-Position: refs/heads/master@{#412989} ==========
Message was sent while issue was closed.
Committed patchset #13 (id:240001)
Message was sent while issue was closed.
Description was changed from ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 Cr-Original-Original-Commit-Position: refs/heads/master@{#409197} Cr-Original-Commit-Position: refs/heads/master@{#412685} Cr-Commit-Position: refs/heads/master@{#412989} ========== to ========== Fix ineffective --disable-gpu-driver-bug-workarounds It was hidden to the user since chrome://gpu was not showing any workarounds, but they were still applied in the gpu process. Also add a gpu test that sets --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND in both browser and gpu processes. BUG=359367 R=kbr@chromium.org, zmo@chromium.org TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 Committed: https://crrev.com/31f3d211396da3c7ca23684b6582554f0f6738b0 Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#409197} Cr-Original-Original-Commit-Position: refs/heads/master@{#412685} Cr-Original-Commit-Position: refs/heads/master@{#412989} Cr-Commit-Position: refs/heads/master@{#413411} ==========
Message was sent while issue was closed.
Patchset 13 (id:??) landed as https://crrev.com/31f3d211396da3c7ca23684b6582554f0f6738b0 Cr-Commit-Position: refs/heads/master@{#413411} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
