Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2257373002: Revert of Fix ineffective --disable-gpu-driver-bug-workarounds (Closed)

Created:
4 years, 4 months ago by Julien Isorce Samsung
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix ineffective --disable-gpu-driver-bug-workarounds (patchset #12 id:220001 of https://codereview.chromium.org/2195743005/ ) Reason for revert: Still cause failures on Nexus 9 https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29/builds/1410 But this time I think I understand why. It could be because the test should also record the disabled extensions. To re-apply them manually when passing --disable-gpu-driver-bug-workarounds Original issue's description: > Fix ineffective --disable-gpu-driver-bug-workarounds > > It was hidden to the user since chrome://gpu was not showing > any workarounds, but they were still applied in the gpu process. > > Also add a gpu test that sets > --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing > and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND > in both browser and gpu processes. > > BUG=359367 > > R=kbr@chromium.org, zmo@chromium.org > > TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755 > Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd > Committed: https://crrev.com/87c144ab365dacd92f2bb7720628e3397a44c2d6 > Cr-Original-Original-Commit-Position: refs/heads/master@{#409197} > Cr-Original-Commit-Position: refs/heads/master@{#412685} > Cr-Commit-Position: refs/heads/master@{#412989} TBR=kbr@chromium.org,zmo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=359367 Committed: https://crrev.com/d653d1ef060d8febe17987daa8ee8ce52bd01ce3 Cr-Commit-Position: refs/heads/master@{#413091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -128 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 4 chunks +25 lines, -127 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Julien Isorce Samsung
Created Revert of Fix ineffective --disable-gpu-driver-bug-workarounds
4 years, 4 months ago (2016-08-19 05:35:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257373002/1
4 years, 4 months ago (2016-08-19 05:35:47 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-19 05:36:19 UTC) #5
mlamouri (slow - plz ping)
lgtm
4 years, 4 months ago (2016-08-19 09:03:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257373002/1
4 years, 4 months ago (2016-08-19 09:03:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 09:04:40 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 09:07:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d653d1ef060d8febe17987daa8ee8ce52bd01ce3
Cr-Commit-Position: refs/heads/master@{#413091}

Powered by Google App Engine
This is Rietveld 408576698