Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: content/browser/gpu/gpu_data_manager_impl_private.cc

Issue 2195743005: Fix ineffective --disable-gpu-driver-bug-workarounds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: record and re-apply disabled gl extensions to avoid known gpu driver crashes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/gpu/gpu_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_data_manager_impl_private.cc
diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc
index c7162a7d75048ae232acd7290a7cef47684e6b85..3986a13dba4487d2f28bf5ddc4dbf1a61851806b 100644
--- a/content/browser/gpu/gpu_data_manager_impl_private.cc
+++ b/content/browser/gpu/gpu_data_manager_impl_private.cc
@@ -614,30 +614,33 @@ void GpuDataManagerImplPrivate::UpdateGpuInfoHelper() {
UpdateBlacklistedFeatures(features);
}
+
+ std::set<std::string> disabled_ext_set;
+
+ // Merge disabled extensions from the command line with gpu driver bug list.
+ if (command_line) {
+ const std::vector<std::string>& disabled_command_line_exts =
+ base::SplitString(
+ command_line->GetSwitchValueASCII(switches::kDisableGLExtensions),
+ ", ;", base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
+ disabled_ext_set.insert(disabled_command_line_exts.begin(),
+ disabled_command_line_exts.end());
+ }
+
if (gpu_driver_bug_list_) {
gpu_driver_bugs_ = gpu_driver_bug_list_->MakeDecision(
gpu::GpuControlList::kOsAny, os_version, gpu_info_);
- std::set<std::string> disabled_ext_set;
-
- // Merge disabled extensions from the command line with gpu driver bug list.
- if (command_line) {
- const std::vector<std::string>& disabled_command_line_exts =
- base::SplitString(
- command_line->GetSwitchValueASCII(switches::kDisableGLExtensions),
- ", ;", base::KEEP_WHITESPACE, base::SPLIT_WANT_NONEMPTY);
- disabled_ext_set.insert(disabled_command_line_exts.begin(),
- disabled_command_line_exts.end());
- }
const std::vector<std::string>& disabled_driver_bug_exts =
gpu_driver_bug_list_->GetDisabledExtensions();
disabled_ext_set.insert(disabled_driver_bug_exts.begin(),
disabled_driver_bug_exts.end());
- disabled_extensions_ =
- base::JoinString(std::vector<std::string>(disabled_ext_set.begin(),
- disabled_ext_set.end()),
- " ");
}
+ disabled_extensions_ =
+ base::JoinString(std::vector<std::string>(disabled_ext_set.begin(),
+ disabled_ext_set.end()),
+ " ");
+
gpu::GpuDriverBugList::AppendWorkaroundsFromCommandLine(
&gpu_driver_bugs_, *base::CommandLine::ForCurrentProcess());
« no previous file with comments | « no previous file | content/browser/gpu/gpu_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698