Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2194893002: services/ui: Revert CLs that broke Windows. (Closed)

Created:
4 years, 4 months ago by sadrul
Modified:
4 years, 4 months ago
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, sadrul, tfarina, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Revert CLs that broke Windows. The new GPU code path does not seem to work correctly on Windows yet (everything is black). So restore the deprecated path. Revert "services/ui: Remove deprecated gpu code" crrev.com/408207 Revert "services/ui: Remove unused connector argument" crrev.com/408230 BUG=623157, 630893 TBR=ben@, piman@, penghuang@ Committed: https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d Cr-Commit-Position: refs/heads/master@{#408648}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3381 lines, -186 lines) Patch
M ash/mus/bridge/wm_root_window_controller_mus.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/mus/non_client_frame_controller.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ash/touch_hud/mus/touch_hud_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_mus.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M content/renderer/mus/render_widget_mus_connection.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mash/login/login.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/navigation/view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/common/gpu_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M services/ui/common/gpu_service.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M services/ui/common/switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/common/switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
A services/ui/gles2/BUILD.gn View 1 chunk +89 lines, -0 lines 0 comments Download
A + services/ui/gles2/DEPS View 1 chunk +1 line, -3 lines 0 comments Download
A + services/ui/gles2/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A services/ui/gles2/command_buffer_driver.h View 1 chunk +173 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_driver.cc View 1 chunk +568 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_driver_manager.h View 1 chunk +46 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_driver_manager.cc View 1 chunk +50 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_impl.h View 1 chunk +126 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_impl.cc View 1 chunk +301 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_local.h View 1 chunk +184 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_local.cc View 1 chunk +568 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_local_client.h View 1 chunk +31 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_task_runner.h View 1 chunk +78 lines, -0 lines 0 comments Download
A services/ui/gles2/command_buffer_task_runner.cc View 1 chunk +77 lines, -0 lines 0 comments Download
A services/ui/gles2/gl_surface_adapter.h View 1 chunk +71 lines, -0 lines 0 comments Download
A services/ui/gles2/gl_surface_adapter.cc View 1 chunk +57 lines, -0 lines 0 comments Download
A services/ui/gles2/gpu_impl.h View 1 chunk +39 lines, -0 lines 0 comments Download
A services/ui/gles2/gpu_impl.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A services/ui/gles2/gpu_memory_tracker.h View 1 chunk +39 lines, -0 lines 0 comments Download
A services/ui/gles2/gpu_memory_tracker.cc View 1 chunk +36 lines, -0 lines 0 comments Download
A services/ui/gles2/gpu_state.h View 1 chunk +107 lines, -0 lines 0 comments Download
A services/ui/gles2/gpu_state.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A services/ui/gles2/ozone_gpu_memory_buffer.h View 1 chunk +71 lines, -0 lines 0 comments Download
A services/ui/gles2/ozone_gpu_memory_buffer.cc View 1 chunk +115 lines, -0 lines 0 comments Download
A + services/ui/gles2/raster_thread_helper.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + services/ui/gles2/raster_thread_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M services/ui/public/cpp/bitmap_uploader.h View 2 chunks +5 lines, -1 line 0 comments Download
M services/ui/public/cpp/context_provider.h View 2 chunks +2 lines, -1 line 0 comments Download
M services/ui/public/cpp/gles2_context.h View 2 chunks +8 lines, -2 lines 0 comments Download
M services/ui/public/cpp/lib/bitmap_uploader.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M services/ui/public/cpp/lib/context_provider.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M services/ui/public/cpp/lib/gles2_context.cc View 3 chunks +47 lines, -27 lines 0 comments Download
D services/ui/public/cpp/lib/raster_thread_helper.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D services/ui/public/cpp/raster_thread_helper.h View 1 chunk +0 lines, -34 lines 0 comments Download
M services/ui/service.h View 3 chunks +6 lines, -0 lines 0 comments Download
M services/ui/service.cc View 9 chunks +44 lines, -2 lines 0 comments Download
M services/ui/surfaces/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M services/ui/surfaces/display_compositor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 2 chunks +2 lines, -1 line 0 comments Download
A + services/ui/surfaces/ozone_gpu_memory_buffer_manager.h View 2 chunks +10 lines, -14 lines 0 comments Download
A services/ui/surfaces/ozone_gpu_memory_buffer_manager.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M services/ui/surfaces/surfaces_context_provider.h View 5 chunks +14 lines, -1 line 0 comments Download
M services/ui/surfaces/surfaces_context_provider.cc View 3 chunks +78 lines, -30 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/frame_generator.h View 3 chunks +3 lines, -0 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/ws/platform_display.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M services/ui/ws/platform_display_init_params.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/platform_display_init_params.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_tree_host_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 4 chunks +11 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 4 chunks +21 lines, -1 line 0 comments Download
M ui/views/mus/surface_binding.h View 2 chunks +7 lines, -1 line 0 comments Download
M ui/views/mus/surface_binding.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 3 chunks +8 lines, -3 lines 0 comments Download
M ui/views/mus/surface_context_factory.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
sadrul
Restoring the deprecated GPU codepath for mus, since the new code doesn't work on Windows ...
4 years, 4 months ago (2016-07-29 14:34:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194893002/1
4 years, 4 months ago (2016-07-29 14:34:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/227715)
4 years, 4 months ago (2016-07-29 14:40:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194893002/20001
4 years, 4 months ago (2016-07-29 14:59:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 16:09:15 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f99035fbb67293836944993268f0357ad3d65a4d Cr-Commit-Position: refs/heads/master@{#408648}
4 years, 4 months ago (2016-07-29 16:10:51 UTC) #17
sadrul
4 years, 4 months ago (2016-07-29 19:13:41 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2196503003/ by sadrul@chromium.org.

The reason for reverting is: crrev.com/408695 fixes the issue. So we can reland
these CLs..

Powered by Google App Engine
This is Rietveld 408576698