Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2194683003: [DevTools] Cleanup v8_inspector console API. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Cleanup v8_inspector console API. BUG=631162 TBR=pfeldman Committed: https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b Cr-Commit-Position: refs/heads/master@{#408743}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase, addressed nits #

Patch Set 3 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -91 lines) Patch
M third_party/WebKit/Source/core/inspector/ConsoleTypes.h View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 3 chunks +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp View 1 3 chunks +12 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/public/V8ConsoleTypes.h View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 5 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-07-29 16:43:33 UTC) #2
kozy
lgtm % nits https://codereview.chromium.org/2194683003/diff/1/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right): https://codereview.chromium.org/2194683003/diff/1/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp#newcode59 third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:59: default: return LogMessageLevel; switch(type) { case ...
4 years, 4 months ago (2016-07-29 16:57:37 UTC) #3
dgozman
https://codereview.chromium.org/2194683003/diff/1/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right): https://codereview.chromium.org/2194683003/diff/1/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp#newcode59 third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:59: default: return LogMessageLevel; On 2016/07/29 16:57:37, kozyatinskiy wrote: > ...
4 years, 4 months ago (2016-07-29 17:15:43 UTC) #4
dgozman
TBR'ing pfeldman for gypi
4 years, 4 months ago (2016-07-29 17:16:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194683003/20001
4 years, 4 months ago (2016-07-29 17:16:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/229893)
4 years, 4 months ago (2016-07-29 17:49:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2194683003/40001
4 years, 4 months ago (2016-07-29 19:49:35 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-29 21:07:00 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:09:15 UTC) #18
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e8ef3397193287d76844ea0d16ed4fda5682466b
Cr-Commit-Position: refs/heads/master@{#408743}

Powered by Google App Engine
This is Rietveld 408576698