[DevTools] Cleanup v8_inspector console API.

third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/inspector/ThreadDebugger.h"
 
 #include "bindings/core/v8/SourceLocation.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8DOMException.h"
 #include "bindings/core/v8/V8DOMTokenList.h"
@@ skipping 29 matching lines @@
 
 // static
 ThreadDebugger* ThreadDebugger::from(v8::Isolate* isolate)
 {
     if (!isolate)
         return nullptr;
     V8PerIsolateData* data = V8PerIsolateData::from(isolate);
     return data ? data->threadDebugger() : nullptr;
 }
 
+// static
+MessageLevel ThreadDebugger::consoleAPITypeToMessageLevel(V8ConsoleAPIType type)
+{
+    switch (type) {
+    case V8ConsoleAPIType::kDebug: return DebugMessageLevel;
+    case V8ConsoleAPIType::kLog: return LogMessageLevel;
+    case V8ConsoleAPIType::kInfo: return InfoMessageLevel;
+    case V8ConsoleAPIType::kWarning: return WarningMessageLevel;
+    case V8ConsoleAPIType::kError: return ErrorMessageLevel;
+    default: return LogMessageLevel;

[kozy, 2016/07/29 16:57:37]

switch(type) {
case V8ConsoleAPIType::kDebug: return DebugMessageLevel;
...
case V8ConsoleAPIType::kError: return ErrorMessageLevel;
}
return LogMessageLevel;

to make some old compiler happy.

[dgozman, 2016/07/29 17:15:43]

Done.

+    }
+}
+
 void ThreadDebugger::willExecuteScript(v8::Isolate* isolate, int scriptId)
 {
     if (ThreadDebugger* debugger = ThreadDebugger::from(isolate))
         debugger->debugger()->willExecuteScript(isolate->GetCurrentContext(), scriptId);
 }
 
 void ThreadDebugger::didExecuteScript(v8::Isolate* isolate)
 {
     if (ThreadDebugger* debugger = ThreadDebugger::from(isolate))
         debugger->debugger()->didExecuteScript(isolate->GetCurrentContext());
@@ skipping 317 matching lines @@
 {
     for (size_t index = 0; index < m_timers.size(); ++index) {
         if (m_timers[index].get() == timer) {
             m_timerCallbacks[index](m_timerData[index]);
             return;
         }
     }
 }
 
 } // namespace blink