Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

Issue 2194683003: [DevTools] Cleanup v8_inspector console API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
index 6a572617b47022b7f8bc0fbb26497d98f09c49ae..f747c5606e2b08c141e142fa6905d23e084c7c96 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
@@ -334,16 +334,18 @@ std::unique_ptr<V8ConsoleMessage> V8ConsoleMessage::createForConsoleAPI(double t
if (arguments.size())
message->m_message = V8ValueStringBuilder::toString(arguments[0], context->isolate());
- MessageLevel level = LogMessageLevel;
+ V8ConsoleAPIType clientType = V8ConsoleAPIType::kLog;
if (type == ConsoleAPIType::kDebug || type == ConsoleAPIType::kCount || type == ConsoleAPIType::kTimeEnd)
- level = DebugMessageLevel;
- if (type == ConsoleAPIType::kError || type == ConsoleAPIType::kAssert)
- level = ErrorMessageLevel;
- if (type == ConsoleAPIType::kWarning)
- level = WarningMessageLevel;
- if (type == ConsoleAPIType::kInfo)
- level = InfoMessageLevel;
- context->debugger()->client()->consoleAPIMessage(context->contextGroupId(), level, message->m_message, message->m_url, message->m_lineNumber, message->m_columnNumber, message->m_stackTrace.get());
+ clientType = V8ConsoleAPIType::kDebug;
+ else if (type == ConsoleAPIType::kError || type == ConsoleAPIType::kAssert)
+ clientType = V8ConsoleAPIType::kError;
+ else if (type == ConsoleAPIType::kWarning)
+ clientType = V8ConsoleAPIType::kWarning;
+ else if (type == ConsoleAPIType::kInfo)
+ clientType = V8ConsoleAPIType::kInfo;
+ else if (type == ConsoleAPIType::kClear)
+ clientType = V8ConsoleAPIType::kClear;
+ context->debugger()->client()->consoleAPIMessage(context->contextGroupId(), clientType, message->m_message, message->m_url, message->m_lineNumber, message->m_columnNumber, message->m_stackTrace.get());
return message;
}
@@ -392,15 +394,12 @@ V8ConsoleMessageStorage::V8ConsoleMessageStorage(V8DebuggerImpl* debugger, int c
V8ConsoleMessageStorage::~V8ConsoleMessageStorage()
{
clear();
- notifyClear();
}
void V8ConsoleMessageStorage::addMessage(std::unique_ptr<V8ConsoleMessage> message)
{
- if (message->type() == ConsoleAPIType::kClear) {
+ if (message->type() == ConsoleAPIType::kClear)
clear();
- notifyClear();
- }
V8InspectorSessionImpl* session = m_debugger->sessionForContextGroup(m_contextGroupId);
if (session) {
@@ -431,10 +430,4 @@ void V8ConsoleMessageStorage::contextDestroyed(int contextId)
m_messages[i]->contextDestroyed(contextId);
}
-void V8ConsoleMessageStorage::notifyClear()
-{
- if (V8InspectorSessionImpl* session = m_debugger->sessionForContextGroup(m_contextGroupId))
- session->client()->consoleCleared();
-}
-
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698