Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2194683003: [DevTools] Cleanup v8_inspector console API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 77c7faf609f053153157ab5863ff1c742372c2ca..f94adb1b7f11ee418c48eaddf77386326d31487b 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -312,7 +312,6 @@ WebDevToolsAgentImpl::WebDevToolsAgentImpl(
, m_networkAgent(nullptr)
, m_layerTreeAgent(nullptr)
, m_tracingAgent(nullptr)
- , m_logAgent(nullptr)
, m_includeViewAgents(includeViewAgents)
, m_layerTreeId(0)
{
@@ -350,7 +349,6 @@ DEFINE_TRACE(WebDevToolsAgentImpl)
visitor->trace(m_networkAgent);
visitor->trace(m_layerTreeAgent);
visitor->trace(m_tracingAgent);
- visitor->trace(m_logAgent);
visitor->trace(m_session);
}
@@ -410,8 +408,7 @@ void WebDevToolsAgentImpl::initializeSession(int sessionId, const String& hostId
m_pageAgent = pageAgent;
m_session->append(pageAgent);
- m_logAgent = new InspectorLogAgent(&m_inspectedFrames->root()->host()->consoleMessageStorage());
- m_session->append(m_logAgent.get());
+ m_session->append(new InspectorLogAgent(&m_inspectedFrames->root()->host()->consoleMessageStorage()));
m_tracingAgent->setLayerTreeId(m_layerTreeId);
m_networkAgent->setHostId(hostId);
@@ -447,7 +444,6 @@ void WebDevToolsAgentImpl::destroySession()
m_networkAgent.clear();
m_pageAgent.clear();
m_domAgent.clear();
- m_logAgent.clear();
m_session->dispose();
m_session.clear();
@@ -610,14 +606,6 @@ void WebDevToolsAgentImpl::profilingStopped()
m_overlay->resume();
}
-void WebDevToolsAgentImpl::consoleCleared()
-{
- if (m_domAgent)
- m_domAgent->releaseDanglingNodes();
- if (m_logAgent)
- m_logAgent->clear(nullptr);
-}
-
void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized)
{
if (m_overlay)
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698