Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2193593003: GN: Always quote cc and cxx. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: Always quote cc and cxx. To fix: ERROR at the command-line "--args":1:34: Unexpected token '+' is_debug=true cc=clang cxx=clang++ TBR=jcgregorio@google.com NOTRY=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193593003 Committed: https://skia.googlesource.com/skia/+/2a1134e3f5015afe596703a584a63f5bcd375836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M infra/bots/recipe_modules/skia/gn_flavor.py View 1 chunk +2 lines, -2 lines 0 comments Download
M infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
mtklein_C
4 years, 4 months ago (2016-07-29 12:38:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2193593003/1
4 years, 4 months ago (2016-07-29 12:38:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/2a1134e3f5015afe596703a584a63f5bcd375836
4 years, 4 months ago (2016-07-29 12:39:38 UTC) #9
jcgregorio
4 years, 4 months ago (2016-07-29 13:33:57 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698