infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json - Issue 2193593003: GN: Always quote cc and cxx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json

Issue 2193593003: GN: Always quote cc and cxx. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json

diff --git a/infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json b/infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json

index 95fbeb6d2f0b6ecfb40660631162ce73b4361213..8a4a746ba5993c32afc2037a484585b02c9b7288 100644

--- a/infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json

+++ b/infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json

@@ -131,7 +131,7 @@

"gn.exe",

"gen",

"[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Release-GN\\Release",

- "--args=is_debug=false cc=cc cxx=c++"

+ "--args=is_debug=false cc=\"cc\" cxx=\"c++\""

"cwd": "[CUSTOM_C:\\_B_WORK]\\skia",

"env": {

« no previous file with comments | « infra/bots/recipe_modules/skia/gn_flavor.py ('k') | no next file » | no next file with comments »