Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json

Issue 2193593003: GN: Always quote cc and cxx. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « infra/bots/recipe_modules/skia/gn_flavor.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 [ 1 [
2 { 2 {
3 "cmd": [ 3 "cmd": [
4 "python", 4 "python",
5 "-u", 5 "-u",
6 "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os. path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n", 6 "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os. path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",
7 "[CUSTOM_C:\\_B_WORK]", 7 "[CUSTOM_C:\\_B_WORK]",
8 "511" 8 "511"
9 ], 9 ],
10 "name": "makedirs checkout_path", 10 "name": "makedirs checkout_path",
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools];RECIPE_PACKAGE_REPO[dep ot_tools]", 124 "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools];RECIPE_PACKAGE_REPO[dep ot_tools]",
125 "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Release-G N" 125 "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Release-G N"
126 }, 126 },
127 "name": "fetch-gn" 127 "name": "fetch-gn"
128 }, 128 },
129 { 129 {
130 "cmd": [ 130 "cmd": [
131 "gn.exe", 131 "gn.exe",
132 "gen", 132 "gen",
133 "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Release-GN\\Release", 133 "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Release-GN\\Release",
134 "--args=is_debug=false cc=cc cxx=c++" 134 "--args=is_debug=false cc=\"cc\" cxx=\"c++\""
135 ], 135 ],
136 "cwd": "[CUSTOM_C:\\_B_WORK]\\skia", 136 "cwd": "[CUSTOM_C:\\_B_WORK]\\skia",
137 "env": { 137 "env": {
138 "BUILDTYPE": "Release", 138 "BUILDTYPE": "Release",
139 "CHROME_HEADLESS": "1", 139 "CHROME_HEADLESS": "1",
140 "GYP_DEFINES": "qt_sdk=C:/Qt/4.8.5/ skia_arch_type=x86 skia_warnings_as_er rors=1 skia_win_debuggers_path=c:/DbgHelp skia_win_ltcg=0", 140 "GYP_DEFINES": "qt_sdk=C:/Qt/4.8.5/ skia_arch_type=x86 skia_warnings_as_er rors=1 skia_win_debuggers_path=c:/DbgHelp skia_win_ltcg=0",
141 "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools];RECIPE_PACKAGE_REPO[dep ot_tools]", 141 "PATH": "%(PATH)s;RECIPE_PACKAGE_REPO[depot_tools];RECIPE_PACKAGE_REPO[dep ot_tools]",
142 "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Release-G N" 142 "SKIA_OUT": "[CUSTOM_C:\\_B_WORK]\\skia\\out\\Build-Win-MSVC-x86-Release-G N"
143 }, 143 },
144 "name": "gn_gen" 144 "name": "gn_gen"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 "@@@STEP_LOG_LINE@python.inline@ pass@@@", 213 "@@@STEP_LOG_LINE@python.inline@ pass@@@",
214 "@@@STEP_LOG_END@python.inline@@@" 214 "@@@STEP_LOG_END@python.inline@@@"
215 ] 215 ]
216 }, 216 },
217 { 217 {
218 "name": "$result", 218 "name": "$result",
219 "recipe_result": null, 219 "recipe_result": null,
220 "status_code": 0 220 "status_code": 0
221 } 221 }
222 ] 222 ]
OLDNEW
« no previous file with comments | « infra/bots/recipe_modules/skia/gn_flavor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698