Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: infra/bots/recipe_modules/skia/gn_flavor.py

Issue 2193593003: GN: Always quote cc and cxx. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipe_modules/skia/gn_flavor.py
diff --git a/infra/bots/recipe_modules/skia/gn_flavor.py b/infra/bots/recipe_modules/skia/gn_flavor.py
index cdb26e0631f9b192d891fc6f540047859d7a0b11..c4988fbe16a6df7962e4159ee3eb340fe894e1ed 100644
--- a/infra/bots/recipe_modules/skia/gn_flavor.py
+++ b/infra/bots/recipe_modules/skia/gn_flavor.py
@@ -26,9 +26,9 @@ class GNFlavorUtils(default_flavor.DefaultFlavorUtils):
ccache = self._skia_api.ccache()
if ccache:
- cc, cxx = '"%s %s"' % (ccache, cc), '"%s %s"' % (ccache, cxx)
+ cc, cxx = '%s %s' % (ccache, cc), '%s %s' % (ccache, cxx)
- gn_args += [ 'cc=' + cc, 'cxx=' + cxx ]
+ gn_args += [ 'cc="%s"' % cc, 'cxx="%s"' % cxx ]
# Run gn gen.
gn_exe = 'gn'
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_compile.expected/Build-Win-MSVC-x86-Release-GN.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698