Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2192403002: Remove MockOptions, and replace all usages of it with optparse.Values. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MockOptions, and replace all usages of it with optparse.Values. BUG=626679 Committed: https://crrev.com/74240f45edec9d1eea8ca24b27250418a44c07b9 Cr-Commit-Position: refs/heads/master@{#410593}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -180 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py View 8 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py View 3 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 8 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 4 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/analyze_baselines_unittest.py View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/auto_rebaseline_unittest.py View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command_test.py View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py View 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/queries_unittest.py View 5 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs_unittest.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 2 29 chunks +124 lines, -67 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
qyearsley
4 years, 4 months ago (2016-08-02 16:19:37 UTC) #2
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-09 00:35:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192403002/40001
4 years, 4 months ago (2016-08-09 04:54:07 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-09 06:04:28 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 06:06:54 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/74240f45edec9d1eea8ca24b27250418a44c07b9
Cr-Commit-Position: refs/heads/master@{#410593}

Powered by Google App Engine
This is Rietveld 408576698