third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py - Issue 2192403002: Remove MockOptions, and replace all usages of it with optparse.Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py

Issue 2192403002: Remove MockOptions, and replace all usages of it with optparse.Values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py

index 97aac7f5643da89d4a91c9f3b922a099acf2d6f7..2229b5cd1d5404772f07f638842c87a162ff7868 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/mock_tool.py

@@ -26,19 +26,9 @@

# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-import optparse

from webkitpy.common.host_mock import MockHost

-# TODO(qyearsley): Replace uses of this with using optparse.Values directly (crbug.com/626679).

-class MockOptions(optparse.Values):

- def __init__(self, **kwargs):

- # Not using super because optparse.Values is an old-style class.

- optparse.Values.__init__(self, defaults=kwargs)

class MockWebKitPatch(MockHost):

def __init__(self, *args, **kwargs):

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py ('k') | no next file » | no next file with comments »