third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py - Issue 2192403002: Remove MockOptions, and replace all usages of it with optparse.Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py

Issue 2192403002: Remove MockOptions, and replace all usages of it with optparse.Values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/command_test.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/optimize_baselines_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py

index ad3851592617aeb52f4935fb1db9ae7afe920787..73c1d2df4c57042f81938abcc5007cb1eb0a9273 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flaky_tests_unittest.py

@@ -2,11 +2,13 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+import optparse

from webkitpy.layout_tests.builder_list import BuilderList

from webkitpy.layout_tests.layout_package import bot_test_expectations

from webkitpy.tool.commands import flaky_tests

from webkitpy.tool.commands.command_test import CommandsTest

-from webkitpy.tool.mock_tool import MockWebKitPatch, MockOptions

+from webkitpy.tool.mock_tool import MockWebKitPatch

class FakeBotTestExpectations(object):

@@ -73,7 +75,7 @@ class FlakyTestsTest(CommandsTest):

tool = MockWebKitPatch()

tool.builders = self.fake_builders_list()

command.expectations_factory = FakeBotTestExpectationsFactory

- options = MockOptions(upload=True)

+ options = optparse.Values({'upload': True})

expected_stdout = flaky_tests.FlakyTests.OUTPUT % (

flaky_tests.FlakyTests.HEADER,

'',