Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py

Issue 2192403002: Remove MockOptions, and replace all usages of it with optparse.Values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
index 613d469fd77b41a1a44528b0ebbc9cc91331bf52..32c9e143a8a83cc8a48373a991dbe4608d4d0084 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py
@@ -29,6 +29,7 @@
"""Unit tests for MockDRT."""
import io
+import optparse
import unittest
from webkitpy.common.system.systemhost_mock import MockSystemHost
@@ -36,15 +37,11 @@ from webkitpy.layout_tests.port import mock_drt
from webkitpy.layout_tests.port import port_testcase
from webkitpy.layout_tests.port import test
from webkitpy.layout_tests.port.factory import PortFactory
-from webkitpy.tool.mock_tool import MockOptions
-
-
-mock_options = MockOptions(configuration='Release')
class MockDRTPortTest(port_testcase.PortTestCase):
- def make_port(self, host=None, options=mock_options):
+ def make_port(self, host=None, options=optparse.Values({'configuration': 'Release'})):
host = host or MockSystemHost()
test.add_unit_tests_to_mock_filesystem(host.filesystem)
return mock_drt.MockDRTPort(host, port_name='mock-mac', options=options)

Powered by Google App Engine
This is Rietveld 408576698