Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2192383002: Add equality and empty tests for first_contentful_paint (Closed)

Created:
4 years, 4 months ago by Bryan McQuade
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Add equality and empty tests for first_contentful_paint ksakamoto discovered that our PageLoadTiming code is missing equality/empty tests for the first_contentful_paint field. This means that when FCP is different from FP, and no subsequent metrics are logged for a given page, FCP may erroneously not get logged for that page. BUG=632765 TBR=csharrison NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2195743002 Cr-Commit-Position: refs/heads/master@{#408674} (cherry picked from commit faa55192bc07e10058fef50dfcc3531afeef6a13)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/page_load_metrics/common/page_load_timing.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2192383002/1
4 years, 4 months ago (2016-07-31 14:20:35 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-31 14:22:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698