Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2195743002: Add equality and empty tests for first_contentful_paint (Closed)

Created:
4 years, 4 months ago by Bryan McQuade
Modified:
4 years, 4 months ago
Reviewers:
Charlie Harrison
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org, Kunihiko Sakamoto
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add equality and empty tests for first_contentful_paint ksakamoto discovered that our PageLoadTiming code is missing equality/empty tests for the first_contentful_paint field. This means that when FCP is different from FP, and no subsequent metrics are logged for a given page, FCP may erroneously not get logged for that page. BUG=632765 Committed: https://crrev.com/faa55192bc07e10058fef50dfcc3531afeef6a13 Cr-Commit-Position: refs/heads/master@{#408674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/common/page_load_metrics/page_load_timing.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Bryan McQuade
PTAL
4 years, 4 months ago (2016-07-29 16:28:29 UTC) #3
Charlie Harrison
*sigh* lgtm but I would really love it if we could add some static checks ...
4 years, 4 months ago (2016-07-29 16:54:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2195743002/1
4 years, 4 months ago (2016-07-29 17:17:42 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 17:23:48 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 17:28:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faa55192bc07e10058fef50dfcc3531afeef6a13
Cr-Commit-Position: refs/heads/master@{#408674}

Powered by Google App Engine
This is Rietveld 408576698