Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: components/page_load_metrics/common/page_load_timing.cc

Issue 2192383002: Add equality and empty tests for first_contentful_paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/common/page_load_timing.h" 5 #include "components/page_load_metrics/common/page_load_timing.h"
6 6
7 namespace page_load_metrics { 7 namespace page_load_metrics {
8 8
9 PageLoadTiming::PageLoadTiming() {} 9 PageLoadTiming::PageLoadTiming() {}
10 10
11 PageLoadTiming::PageLoadTiming(const PageLoadTiming& other) = default; 11 PageLoadTiming::PageLoadTiming(const PageLoadTiming& other) = default;
12 12
13 PageLoadTiming::~PageLoadTiming() {} 13 PageLoadTiming::~PageLoadTiming() {}
14 14
15 bool PageLoadTiming::operator==(const PageLoadTiming& other) const { 15 bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
16 return navigation_start == other.navigation_start && 16 return navigation_start == other.navigation_start &&
17 response_start == other.response_start && 17 response_start == other.response_start &&
18 dom_loading == other.dom_loading && 18 dom_loading == other.dom_loading &&
19 dom_content_loaded_event_start == 19 dom_content_loaded_event_start ==
20 other.dom_content_loaded_event_start && 20 other.dom_content_loaded_event_start &&
21 load_event_start == other.load_event_start && 21 load_event_start == other.load_event_start &&
22 first_layout == other.first_layout && 22 first_layout == other.first_layout &&
23 first_paint == other.first_paint && 23 first_paint == other.first_paint &&
24 first_text_paint == other.first_text_paint && 24 first_text_paint == other.first_text_paint &&
25 first_image_paint == other.first_image_paint && 25 first_image_paint == other.first_image_paint &&
26 first_contentful_paint == other.first_contentful_paint &&
26 parse_start == other.parse_start && parse_stop == other.parse_stop && 27 parse_start == other.parse_start && parse_stop == other.parse_stop &&
27 parse_blocked_on_script_load_duration == 28 parse_blocked_on_script_load_duration ==
28 other.parse_blocked_on_script_load_duration && 29 other.parse_blocked_on_script_load_duration &&
29 parse_blocked_on_script_load_from_document_write_duration == 30 parse_blocked_on_script_load_from_document_write_duration ==
30 other.parse_blocked_on_script_load_from_document_write_duration; 31 other.parse_blocked_on_script_load_from_document_write_duration;
31 } 32 }
32 33
33 bool PageLoadTiming::IsEmpty() const { 34 bool PageLoadTiming::IsEmpty() const {
34 return navigation_start.is_null() && response_start.is_zero() && 35 return navigation_start.is_null() && response_start.is_zero() &&
35 dom_loading.is_zero() && dom_content_loaded_event_start.is_zero() && 36 dom_loading.is_zero() && dom_content_loaded_event_start.is_zero() &&
36 load_event_start.is_zero() && first_layout.is_zero() && 37 load_event_start.is_zero() && first_layout.is_zero() &&
37 first_paint.is_zero() && first_text_paint.is_zero() && 38 first_paint.is_zero() && first_text_paint.is_zero() &&
38 first_image_paint.is_zero() && parse_start.is_zero() && 39 first_image_paint.is_zero() && first_contentful_paint.is_zero() &&
39 parse_stop.is_zero() && 40 parse_start.is_zero() && parse_stop.is_zero() &&
40 parse_blocked_on_script_load_duration.is_zero() && 41 parse_blocked_on_script_load_duration.is_zero() &&
41 parse_blocked_on_script_load_from_document_write_duration.is_zero(); 42 parse_blocked_on_script_load_from_document_write_duration.is_zero();
42 } 43 }
43 44
44 PageLoadMetadata::PageLoadMetadata() {} 45 PageLoadMetadata::PageLoadMetadata() {}
45 46
46 bool PageLoadMetadata::operator==(const PageLoadMetadata& other) const { 47 bool PageLoadMetadata::operator==(const PageLoadMetadata& other) const {
47 return behavior_flags == other.behavior_flags; 48 return behavior_flags == other.behavior_flags;
48 } 49 }
49 50
50 } // namespace page_load_metrics 51 } // namespace page_load_metrics
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698