Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: components/page_load_metrics/common/page_load_timing.cc

Issue 2192383002: Add equality and empty tests for first_contentful_paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/page_load_metrics/common/page_load_timing.cc
diff --git a/components/page_load_metrics/common/page_load_timing.cc b/components/page_load_metrics/common/page_load_timing.cc
index 1c3de6553a7fe927a0490b247342d188f7ae60a2..b46632d1f7db4057a3e17e89b1d71588243a20bf 100644
--- a/components/page_load_metrics/common/page_load_timing.cc
+++ b/components/page_load_metrics/common/page_load_timing.cc
@@ -23,6 +23,7 @@ bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
first_paint == other.first_paint &&
first_text_paint == other.first_text_paint &&
first_image_paint == other.first_image_paint &&
+ first_contentful_paint == other.first_contentful_paint &&
parse_start == other.parse_start && parse_stop == other.parse_stop &&
parse_blocked_on_script_load_duration ==
other.parse_blocked_on_script_load_duration &&
@@ -35,8 +36,8 @@ bool PageLoadTiming::IsEmpty() const {
dom_loading.is_zero() && dom_content_loaded_event_start.is_zero() &&
load_event_start.is_zero() && first_layout.is_zero() &&
first_paint.is_zero() && first_text_paint.is_zero() &&
- first_image_paint.is_zero() && parse_start.is_zero() &&
- parse_stop.is_zero() &&
+ first_image_paint.is_zero() && first_contentful_paint.is_zero() &&
+ parse_start.is_zero() && parse_stop.is_zero() &&
parse_blocked_on_script_load_duration.is_zero() &&
parse_blocked_on_script_load_from_document_write_duration.is_zero();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698