Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2189263004: [DevTools] Replace profiling{Started,Stopped} with explicit setOverlaySuspended call. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Replace profiling{Started,Stopped} with explicit setOverlaySuspended call. BUG=631162 Committed: https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c Cr-Commit-Position: refs/heads/master@{#408856}

Patch Set 1 #

Total comments: 2

Patch Set 2 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -59 lines) Patch
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 4 chunks +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorSession.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/OverlayController.js View 1 1 chunk +12 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSessionClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 1 chunk +8 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dgozman
Could you please take a look?
4 years, 4 months ago (2016-07-30 00:46:01 UTC) #2
kozy
https://codereview.chromium.org/2189263004/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2189263004/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json#newcode463 third_party/WebKit/Source/core/inspector/browser_protocol.json:463: "name": "setOverlayMessage", Can we merge setOverlayMessage and setOverlaySuspended in ...
4 years, 4 months ago (2016-07-30 00:55:11 UTC) #3
dgozman
PTAL https://codereview.chromium.org/2189263004/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json File third_party/WebKit/Source/core/inspector/browser_protocol.json (right): https://codereview.chromium.org/2189263004/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json#newcode463 third_party/WebKit/Source/core/inspector/browser_protocol.json:463: "name": "setOverlayMessage", On 2016/07/30 00:55:11, kozyatinskiy wrote: > ...
4 years, 4 months ago (2016-07-30 01:44:38 UTC) #4
kozy
lgtm
4 years, 4 months ago (2016-07-30 01:51:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189263004/20001
4 years, 4 months ago (2016-07-30 02:03:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-30 03:25:45 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 03:27:56 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/02c23fc6d8a185917e1c936fa5a7b9a1c9fa309c
Cr-Commit-Position: refs/heads/master@{#408856}

Powered by Google App Engine
This is Rietveld 408576698