Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2189263004: [DevTools] Replace profiling{Started,Stopped} with explicit setOverlaySuspended call. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merged Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 576 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 void WebDevToolsAgentImpl::resumeStartup() 587 void WebDevToolsAgentImpl::resumeStartup()
588 { 588 {
589 // If we've paused for createWindow, handle it ourselves. 589 // If we've paused for createWindow, handle it ourselves.
590 if (ClientMessageLoopAdapter::resumeForCreateWindow()) 590 if (ClientMessageLoopAdapter::resumeForCreateWindow())
591 return; 591 return;
592 // Otherwise, pass to the client (embedded workers do it differently). 592 // Otherwise, pass to the client (embedded workers do it differently).
593 if (m_client) 593 if (m_client)
594 m_client->resumeStartup(); 594 m_client->resumeStartup();
595 } 595 }
596 596
597 void WebDevToolsAgentImpl::profilingStarted()
598 {
599 if (m_overlay)
600 m_overlay->suspend();
601 }
602
603 void WebDevToolsAgentImpl::profilingStopped()
604 {
605 if (m_overlay)
606 m_overlay->resume();
607 }
608
609 void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized) 597 void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized)
610 { 598 {
611 if (m_overlay) 599 if (m_overlay)
612 m_overlay->pageLayoutInvalidated(resized); 600 m_overlay->pageLayoutInvalidated(resized);
613 } 601 }
614 602
615 void WebDevToolsAgentImpl::setPausedInDebuggerMessage(const String& message) 603 void WebDevToolsAgentImpl::configureOverlay(bool suspended, const String& messag e)
616 { 604 {
617 if (m_overlay) 605 if (!m_overlay)
618 m_overlay->setPausedInDebuggerMessage(message); 606 return;
607 m_overlay->setPausedInDebuggerMessage(message);
608 if (suspended)
609 m_overlay->suspend();
610 else
611 m_overlay->resume();
619 } 612 }
620 613
621 void WebDevToolsAgentImpl::waitForCreateWindow(LocalFrame* frame) 614 void WebDevToolsAgentImpl::waitForCreateWindow(LocalFrame* frame)
622 { 615 {
623 if (!attached()) 616 if (!attached())
624 return; 617 return;
625 if (m_client && m_client->requestDevToolsForFrame(WebLocalFrameImpl::fromFra me(frame))) 618 if (m_client && m_client->requestDevToolsForFrame(WebLocalFrameImpl::fromFra me(frame)))
626 ClientMessageLoopAdapter::pauseForCreateWindow(m_webLocalFrameImpl); 619 ClientMessageLoopAdapter::pauseForCreateWindow(m_webLocalFrameImpl);
627 } 620 }
628 621
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
675 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) 668 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method)
676 { 669 {
677 return method == "Debugger.pause" 670 return method == "Debugger.pause"
678 || method == "Debugger.setBreakpoint" 671 || method == "Debugger.setBreakpoint"
679 || method == "Debugger.setBreakpointByUrl" 672 || method == "Debugger.setBreakpointByUrl"
680 || method == "Debugger.removeBreakpoint" 673 || method == "Debugger.removeBreakpoint"
681 || method == "Debugger.setBreakpointsActive"; 674 || method == "Debugger.setBreakpointsActive";
682 } 675 }
683 676
684 } // namespace blink 677 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698