third_party/WebKit/Source/core/inspector/browser_protocol.json - Issue 2189263004: [DevTools] Replace profiling{Started,Stopped} with explicit setOverlaySuspended call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2189263004: [DevTools] Replace profiling{Started,Stopped} with explicit setOverlaySuspended call. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merged Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorSession.cpp ('k') | third_party/WebKit/Source/devtools/front_end/main/OverlayController.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/browser_protocol.json

diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json

index f4d307b33c5ffbe35699c72724fb074a7dcf7057..dc6e5603ff8b24f0eb3a4e2f86a8acad750bf40f 100644

--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json

+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json

@@ -460,12 +460,13 @@

"handlers": ["browser"]

{

- "name": "setOverlayMessage",

+ "name": "configureOverlay",

"parameters": [

- { "name": "message", "type": "string", "optional": true, "description": "Overlay message to display when paused in debugger." }

+ { "name": "suspended", "type": "boolean", "optional": true, "description": "Whether overlay should be suspended and not consume any resources." },

+ { "name": "message", "type": "string", "optional": true, "description": "Overlay message to display." }

"hidden": true,

- "description": "Sets overlay message."

+ "description": "Configures overlay."

{

"name": "getAppManifest",