Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2189263004: [DevTools] Replace profiling{Started,Stopped} with explicit setOverlaySuspended call. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merged Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index f94adb1b7f11ee418c48eaddf77386326d31487b..2482f6f7baa310dbb8829bf01ab20329363d47af 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -594,28 +594,21 @@ void WebDevToolsAgentImpl::resumeStartup()
m_client->resumeStartup();
}
-void WebDevToolsAgentImpl::profilingStarted()
-{
- if (m_overlay)
- m_overlay->suspend();
-}
-
-void WebDevToolsAgentImpl::profilingStopped()
-{
- if (m_overlay)
- m_overlay->resume();
-}
-
void WebDevToolsAgentImpl::pageLayoutInvalidated(bool resized)
{
if (m_overlay)
m_overlay->pageLayoutInvalidated(resized);
}
-void WebDevToolsAgentImpl::setPausedInDebuggerMessage(const String& message)
+void WebDevToolsAgentImpl::configureOverlay(bool suspended, const String& message)
{
- if (m_overlay)
- m_overlay->setPausedInDebuggerMessage(message);
+ if (!m_overlay)
+ return;
+ m_overlay->setPausedInDebuggerMessage(message);
+ if (suspended)
+ m_overlay->suspend();
+ else
+ m_overlay->resume();
}
void WebDevToolsAgentImpl::waitForCreateWindow(LocalFrame* frame)
« no previous file with comments | « third_party/WebKit/Source/web/WebDevToolsAgentImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698