[arc-intents] Properly qualify API-generated page transitions.

[arc-intents] Properly qualify API-generated page transitions.

Unqualified page transitions are treated as link-clicks, which can get
sent to android via the arc intent mechanism.  This can result in
infinite-looping if the URL that is being opened originated from android
in the first place.

Marking this as an API-generated page transition ensures that the arc
intent code does not forward this URL back to android.

BUG=632360
Committed: https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918
Cr-Commit-Position: refs/heads/master@{#408775}

[Ben Kwa, 2016-07-28 15:41:30]

kenobi@chromium.org changed reviewers:
+ oshima@chromium.org

[Ben Kwa, 2016-07-29 19:11:30]

kenobi@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Ben Kwa, 2016-07-29 19:11:30]

Per oshima@, rename "OpenUrl" to "OpenUrlFromArc" to avoid accidental misuse.

+R lhchavez for ArcIntentHelperBridge.

[Luis Héctor Chávez, 2016-07-29 19:15:52]

components/arc lgtm

[oshima, 2016-07-29 19:17:19]

lgtm

https://codereview.chromium.org/2189063002/diff/1/chrome/browser/ui/ash/chrom...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://codereview.chromium.org/2189063002/diff/1/chrome/browser/ui/ash/chrom...
chrome/browser/ui/ash/chrome_shell_delegate.cc:9: #include <limits>
thanks:)

[Ben Kwa, 2016-07-29 19:22:59]

The CQ bit was checked by kenobi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 19:23:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 19:35:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 19:35:58]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Ben Kwa, 2016-07-29 20:55:28]

The CQ bit was checked by kenobi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 20:56:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 21:30:25]

Dry run: This issue passed the CQ dry run.

[Ben Kwa, 2016-07-29 21:36:13]

The CQ bit was checked by kenobi@chromium.org

[Ben Kwa, 2016-07-29 21:36:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2189063002/#ps40001
(title: "Fix new occurance of an OpenUrl call.")

[commit-bot: I haz the power, 2016-07-29 21:36:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:40:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-29 21:43:07]

Description was changed from

==========
[arc-intents] Properly qualify API-generated page transitions.

Unqualified page transitions are treated as link-clicks, which can get
sent to android via the arc intent mechanism.  This can result in
infinite-looping if the URL that is being opened originated from android
in the first place.

Marking this as an API-generated page transition ensures that the arc
intent code does not forward this URL back to android.

BUG=632360
==========

to

==========
[arc-intents] Properly qualify API-generated page transitions.

Unqualified page transitions are treated as link-clicks, which can get
sent to android via the arc intent mechanism.  This can result in
infinite-looping if the URL that is being opened originated from android
in the first place.

Marking this as an API-generated page transition ensures that the arc
intent code does not forward this URL back to android.

BUG=632360

Committed: https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918
Cr-Commit-Position: refs/heads/master@{#408775}
==========

[commit-bot: I haz the power, 2016-07-29 21:43:08]

Patchset 3 (id:??) landed as
https://crrev.com/b7af62bdaac59bc72d4a87581243a2ce634d0918
Cr-Commit-Position: refs/heads/master@{#408775}

[vkuzkokov, 2017-06-09 14:00:08]

vkuzkokov@chromium.org changed reviewers:
+ vkuzkokov@chromium.org

[vkuzkokov, 2017-06-09 14:00:09]

https://codereview.chromium.org/2189063002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_print_service.cc (right):

https://codereview.chromium.org/2189063002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_print_service.cc:51:
ash::WmShell::Get()->delegate()->OpenUrlFromArc(gurl);
This actually opens a file that's in Chrome's /tmp (which is obviously broken
after crrev.com/2464333004)
Is there still a way to do this?

[oshima, 2017-06-09 16:11:13]

On 2017/06/09 14:00:09, vkuzkokov wrote:
>
https://codereview.chromium.org/2189063002/diff/40001/chrome/browser/chromeos...
> File chrome/browser/chromeos/arc/arc_print_service.cc (right):
> 
>
https://codereview.chromium.org/2189063002/diff/40001/chrome/browser/chromeos...
> chrome/browser/chromeos/arc/arc_print_service.cc:51:
> ash::WmShell::Get()->delegate()->OpenUrlFromArc(gurl);
> This actually opens a file that's in Chrome's /tmp (which is obviously broken
> after crrev.com/2464333004)
> Is there still a way to do this?

I'd recommend to contact hashimoto@