chrome/browser/chromeos/arc/arc_print_service.cc - Issue 2189063002: [arc-intents] Properly qualify API-generated page transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_print_service.cc

Issue 2189063002: [arc-intents] Properly qualify API-generated page transitions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix new occurance of an OpenUrl call. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/arc/arc_print_service.cc

diff --git a/chrome/browser/chromeos/arc/arc_print_service.cc b/chrome/browser/chromeos/arc/arc_print_service.cc

index 2e12a4314ac91495a971e90b4ff4be6df77e7e8c..28de889953839e35bfa71d53f4c6f3f8dde43fe8 100644

--- a/chrome/browser/chromeos/arc/arc_print_service.cc

+++ b/chrome/browser/chromeos/arc/arc_print_service.cc

@@ -48,7 +48,7 @@ void OpenPdf(base::Optional<base::FilePath> file_path) {

return;

GURL gurl = net::FilePathToFileURL(file_path.value());

- ash::WmShell::Get()->delegate()->OpenUrl(gurl);

+ ash::WmShell::Get()->delegate()->OpenUrlFromArc(gurl);

vkuzkokov 2017/06/09 14:00:09 This actually opens a file that's in Chrome's /tmp

// TODO(poromov) Delete file after printing. (http://crbug.com/629843)

}

« no previous file with comments | « ash/test/test_shell_delegate.cc ('k') | chrome/browser/ui/ash/chrome_shell_delegate.h » ('j') | no next file with comments »