ash/common/shell_delegate.h - Issue 2189063002: [arc-intents] Properly qualify API-generated page transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shell_delegate.h

Issue 2189063002: [arc-intents] Properly qualify API-generated page transitions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix new occurance of an OpenUrl call. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/common/shell_delegate.h

diff --git a/ash/common/shell_delegate.h b/ash/common/shell_delegate.h

index 11ffaf3c826b439043092a72b6d920c28033c104..a4c32c446981067880c599b875f11118e6310c24 100644

--- a/ash/common/shell_delegate.h

+++ b/ash/common/shell_delegate.h

@@ -96,7 +96,7 @@ class ASH_EXPORT ShellDelegate {

virtual keyboard::KeyboardUI* CreateKeyboardUI() = 0;

// Opens the |url| in a new browser tab.

- virtual void OpenUrl(const GURL& url) = 0;

+ virtual void OpenUrlFromArc(const GURL& url) = 0;

// Get the AppListPresenter. Ownership stays with Chrome.

virtual app_list::AppListPresenter* GetAppListPresenter() = 0;

« no previous file with comments | « no previous file | ash/mus/shell_delegate_mus.h » ('j') | chrome/browser/chromeos/arc/arc_print_service.cc » ('J')