Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: chrome/browser/ui/ash/chrome_shell_delegate.cc

Issue 2189063002: [arc-intents] Properly qualify API-generated page transitions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix new occurance of an OpenUrl call. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/chrome_shell_delegate.cc
diff --git a/chrome/browser/ui/ash/chrome_shell_delegate.cc b/chrome/browser/ui/ash/chrome_shell_delegate.cc
index eb20851f05d5e91e1374403e04dcad04e064d8f3..1ec0dbe30a073898f784f0d187a943b9f8c3d465 100644
--- a/chrome/browser/ui/ash/chrome_shell_delegate.cc
+++ b/chrome/browser/ui/ash/chrome_shell_delegate.cc
@@ -6,6 +6,8 @@
#include <stddef.h>
+#include <limits>
+
#include "ash/accelerators/magnifier_key_scroller.h"
#include "ash/accelerators/spoken_feedback_toggler.h"
#include "ash/aura/wm_window_aura.h"
@@ -398,14 +400,16 @@ void ChromeShellDelegate::Exit() {
chrome::AttemptUserExit();
}
-void ChromeShellDelegate::OpenUrl(const GURL& url) {
+void ChromeShellDelegate::OpenUrlFromArc(const GURL& url) {
if (!url.is_valid())
return;
chrome::ScopedTabbedBrowserDisplayer displayer(
ProfileManager::GetActiveUserProfile());
- chrome::AddSelectedTabWithURL(displayer.browser(), url,
- ui::PAGE_TRANSITION_LINK);
+ chrome::AddSelectedTabWithURL(
+ displayer.browser(), url,
+ ui::PageTransitionFromInt(ui::PAGE_TRANSITION_LINK |
+ ui::PAGE_TRANSITION_FROM_API));
// Since the ScopedTabbedBrowserDisplayer does not guarantee that the
// browser will be shown on the active desktop, we ensure the visibility.

Powered by Google App Engine
This is Rietveld 408576698