Add a generated ComputedStyleBase class that ComputedStyle extends

Add a generated ComputedStyleBase class that ComputedStyle extends

Add a generated ComputedStyleBase class that ComputedStyle extends from,
as well as a generated ComputedStyleBaseConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in ComputedStyleBase and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
ComputedStyleBase and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tWxg/edit

BUG=628043
Committed: https://crrev.com/8439075a9356236aa3f893f67f23faab867baccf
Cr-Commit-Position: refs/heads/master@{#420508}

[sashab, 2016-07-27 03:13:30]

Description was changed from

==========
done

wip

wip

compiling omfg

wip

wip

done

permissions

done

BUG=
==========

to

==========
Add a generated BaseComputedStyle class that ComputedStyle extends from

Add a generated BaseComputedStyle class that ComputedStyle extends from,
as well as a generated BaseComputedStyleConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in BaseComputedStyle and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
BaseComputedStyle and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043
gcli
==========

[sashab, 2016-07-27 03:15:16]

Description was changed from

==========
Add a generated BaseComputedStyle class that ComputedStyle extends from

Add a generated BaseComputedStyle class that ComputedStyle extends from,
as well as a generated BaseComputedStyleConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in BaseComputedStyle and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
BaseComputedStyle and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043
gcli
==========

to

==========
Add a generated BaseComputedStyle class that ComputedStyle extends

Add a generated BaseComputedStyle class that ComputedStyle extends from,
as well as a generated BaseComputedStyleConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in BaseComputedStyle and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
BaseComputedStyle and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043
gcli
==========

[sashab, 2016-07-27 03:15:48]

Description was changed from

==========
Add a generated BaseComputedStyle class that ComputedStyle extends

Add a generated BaseComputedStyle class that ComputedStyle extends from,
as well as a generated BaseComputedStyleConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in BaseComputedStyle and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
BaseComputedStyle and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043
gcli
==========

to

==========
Add a generated BaseComputedStyle class that ComputedStyle extends

Add a generated BaseComputedStyle class that ComputedStyle extends from,
as well as a generated BaseComputedStyleConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in BaseComputedStyle and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
BaseComputedStyle and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043
==========

[sashab, 2016-07-27 03:23:18]

sashab@chromium.org changed reviewers:
+ rjwright@chromium.org

[sashab, 2016-07-27 03:23:19]

Hey Renee! Please take a look at this patch I wrote to start generating
computedstyle. Thanks!!

https://codereview.chromium.org/2187493004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_base_computed_style.py
(right):

https://codereview.chromium.org/2187493004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_base_computed_style.py:34: Field =
namedtuple('Field', [
This is just a quick way of creating a class in Python. I can do the full class
thing if its not in our style guide or whatever

https://codereview.chromium.org/2187493004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_base_computed_style.py:69: }
Although technically not all 3 things are used in all 3 places... Why not haha

https://codereview.chromium.org/2187493004/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/templates/BaseComputedStyle.h.tmpl
(right):

https://codereview.chromium.org/2187493004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/templates/BaseComputedStyle.h.tmpl:1: {%
from 'macros.tmpl' import license %}
Ugh, this is so hard to read with no syntax highlighting... Here's what it
generates if that helps:

// Copyright (c) 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef BaseComputedStyle_h
#define BaseComputedStyle_h

#include "core/BaseComputedStyleConstants.h"
#include "core/CoreExport.h"
#include "wtf/RefCounted.h"


namespace blink {

// The generated portion of ComputedStyle. For more info, see the header comment
// in ComputedStyle.h.
class CORE_EXPORT BaseComputedStyle : public RefCounted<BaseComputedStyle> {
public:
    ALWAYS_INLINE BaseComputedStyle() :
        RefCounted<BaseComputedStyle>(),
        m_visibility(static_cast<unsigned>(EVisibility::Visible))
    {}
    ~BaseComputedStyle() {}

    ALWAYS_INLINE BaseComputedStyle(const BaseComputedStyle& o) :
        m_visibility(o.m_visibility)
    {}

    bool operator==(const BaseComputedStyle& o) const
    {
        return true
            && m_visibility == o.m_visibility
            && true;
    }

    bool operator!=(const BaseComputedStyle& o) const { return !(*this == o); }

    inline bool inheritedEqual(const BaseComputedStyle& o) const
    {
        return true
            && m_visibility == o.m_visibility
            && true;
    }

    inline bool nonInheritedEqual(const BaseComputedStyle& o) const
    {
        return true
            && true;
    }

    void setBitDefaults()
    {
        resetVisibility();
    }

    void inheritFrom(const BaseComputedStyle& inheritParent, IsAtShadowBoundary
isAtShadowBoundary = NotAtShadowBoundary);

    // Fields.
    // TODO(sashab): Remove initialFoo() static methods and update callers to
    // use resetFoo(), which can be more efficient.
    // visibility
    inline static EVisibility initialVisibility() { return EVisibility::Visible;
}
    EVisibility visibility() const { return
static_cast<EVisibility>(m_visibility); }
    void setVisibility(EVisibility v) { m_visibility = static_cast<unsigned>(v);
}
    inline void resetVisibility() { m_visibility =
static_cast<unsigned>(EVisibility::Visible); }

protected:
    // Storage.
    unsigned m_visibility : 2; // EVisibility
};

} // namespace blink

#endif // BaseComputedStyle_h

https://codereview.chromium.org/2187493004/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/templates/BaseComputedStyle.h.tmpl:44:
&& true;
This && true stuff was just my not-so-clever way of not having to worry about
trailing/leading stuff. Unfortunately there's no way around it in the
initializer list stuff above, but here the && trues should hopefully be
optimized out by the compiler so it should be OK.

[sashab, 2016-07-27 03:24:39]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 03:24:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 03:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 03:54:08]

Dry run: Try jobs failed on following builders:
  win8_chromium_gyp_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp...)

[sashab, 2016-08-01 03:51:35]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 03:51:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 04:21:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 04:21:26]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sashab, 2016-08-02 06:58:00]

esprehn FYI (you'll be reviewing this after Renee :) ), added TODOs to the
generated constants file:

// TODO(sashab): Move these enums to their own namespace, or add a CSS prefix,
// for consistency and to prevent name conflicts.

// TODO(sashab): Add a static_assert when these enums are used in bitfields to
// ensure they use unsigned as the underlying type.

[sashab, 2016-08-09 06:53:56]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 06:54:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 06:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 06:58:14]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sashab, 2016-08-09 07:01:07]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 07:02:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 07:55:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 07:55:22]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sashab, 2016-08-10 01:23:59]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 01:25:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 01:28:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 01:28:54]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-08-10 01:34:52]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 01:35:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 02:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 02:05:25]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sashab, 2016-08-11 08:09:07]

sashab@chromium.org changed reviewers:
+ esprehn@chromium.org
- rjwright@chromium.org

[sashab, 2016-08-11 08:10:01]

I am now aware that BaseComputedStyle has been used in Animations and so
forth... Maybe another name would be better. :)

[esprehn, 2016-08-11 08:39:52]

I think we usually out the base in the other side btw. It's FooBase not
BaseFoo. So this would be ComputedStyleBase.

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[esprehn, 2016-08-11 08:39:54]

I think we usually out the base in the other side btw. It's FooBase not
BaseFoo. So this would be ComputedStyleBase.

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[sashab, 2016-08-18 04:58:16]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 04:58:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 05:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 05:13:44]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[sashab, 2016-09-06 03:59:25]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 03:59:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-09-06 04:19:17]

Description was changed from

==========
Add a generated BaseComputedStyle class that ComputedStyle extends

Add a generated BaseComputedStyle class that ComputedStyle extends from,
as well as a generated BaseComputedStyleConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in BaseComputedStyle and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
BaseComputedStyle and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043
==========

to

==========
Add a generated ComputedStyleBase class that ComputedStyle extends

Add a generated ComputedStyleBase class that ComputedStyle extends from,
as well as a generated ComputedStyleBaseConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in ComputedStyleBase and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
ComputedStyleBase and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043
==========

[commit-bot: I haz the power, 2016-09-06 04:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 04:28:03]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sashab, 2016-09-07 01:54:34]

Done! Please review. Also see WIP follow-up patch if you're interested which
moves the isInherited flag as well: https://codereview.chromium.org/2312823002

[ojan, 2016-09-07 03:46:10]

https://codereview.chromium.org/2187493004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/2187493004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/CSSProperties.in:38: // CSSValueKeywords.in
and use this list instead.
<3

[esprehn, 2016-09-08 22:32:52]

lgtm.

This is how I feel about this patch: http://i.imgur.com/H5KUTKM.gif

https://codereview.chromium.org/2187493004/diff/120001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/build/scripts/templates/ComputedStyleBaseConstants.h.tmpl
(right):

https://codereview.chromium.org/2187493004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/build/scripts/templates/ComputedStyleBaseConstants.h.tmpl:9:
// TODO(sashab): Remove this and update callsites to use a boolean.
hmm, booleans aren't great, can we move this enum out of the generated header
too?

[sashab, 2016-09-08 23:25:12]

LOL @ gif.

Also re the enum: it only has 1 use, here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/style/Com...

and I think isAtShadowBoundary is a pretty clear enum name to be true or false.

It sort of has to be in the generated header because it's needed for the
function signature, ie:
    enum IsAtShadowBoundary {
        AtShadowBoundary,
        NotAtShadowBoundary,
    };

    void inheritFrom(const RenderStyle* inheritParent, IsAtShadowBoundary =
NotAtShadowBoundary);

Patch where it's added:
https://chromium.googlesource.com/chromium/src/+/1c600947ce35e7a6d9c0c04de7d5...

[sashab, 2016-09-09 01:26:51]

On 2016/09/08 at 23:25:12, sashab wrote:
> LOL @ gif.
> 
> Also re the enum: it only has 1 use, here:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/style/Com...
> 
> and I think isAtShadowBoundary is a pretty clear enum name to be true or
false.
> 
> It sort of has to be in the generated header because it's needed for the
function signature, ie:
>     enum IsAtShadowBoundary {
>         AtShadowBoundary,
>         NotAtShadowBoundary,
>     };
> 
>     void inheritFrom(const RenderStyle* inheritParent, IsAtShadowBoundary =
NotAtShadowBoundary);
> 
> Patch where it's added:
>
https://chromium.googlesource.com/chromium/src/+/1c600947ce35e7a6d9c0c04de7d5...

Ahh ok hold on, after reading the blink style guide I think I now understand:
https://www.chromium.org/blink/coding-style
"Prefer enums to bools on function parameters if callers are likely to be
passing constants, since named constants are easier to read at the call site."

Alright, I agree and now understand a bit better :) Moved the enum to the
callsite where its used.

[sashab, 2016-09-09 01:27:09]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-09-09 01:27:10]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2187493004/#ps140001
(title: "Moved enum back to ComputedStyleBase and removed TODO")

[commit-bot: I haz the power, 2016-09-09 01:27:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 02:15:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 02:15:05]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sashab, 2016-09-09 09:11:19]

On 2016/09/09 at 02:15:05, commit-bot wrote:
> Try jobs failed on following builders:
>   chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

Hmm! On chromeos amd64 *only*, ComputedStyle is a different size to what's
expected. Will have more info once https://codereview.chromium.org/2231953003
lands, heh

I wonder what's special about that bot, and how much bigger the object is. Also
just as well we have a size check! :-)

[sashab, 2016-09-15 00:33:53]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 00:34:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 01:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 01:04:10]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sashab, 2016-09-20 00:32:28]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 00:33:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 00:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 00:50:42]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-09-20 00:57:58]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 00:58:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 03:59:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 03:59:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-09-20 05:49:33]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-09-20 05:49:34]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2187493004/#ps200001
(title: "Fixed typo; ComputedStyleBase instead of BaseComputedStyle")

[commit-bot: I haz the power, 2016-09-20 05:49:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 08:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 08:20:29]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-09-22 01:11:17]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 01:11:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 04:22:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 04:22:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sashab, 2016-09-22 05:11:31]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 05:11:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-09-22 05:14:31]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 05:14:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 06:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 06:56:17]

Dry run: This issue passed the CQ dry run.

[sashab, 2016-09-22 23:47:07]

The CQ bit was checked by sashab@chromium.org

[sashab, 2016-09-22 23:47:08]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2187493004/#ps260001
(title: "Re-ordered inheritance to match initializers")

[commit-bot: I haz the power, 2016-09-22 23:47:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:53:49]

Committed patchset #14 (id:260001)

[commit-bot: I haz the power, 2016-09-22 23:56:52]

Description was changed from

==========
Add a generated ComputedStyleBase class that ComputedStyle extends

Add a generated ComputedStyleBase class that ComputedStyle extends from,
as well as a generated ComputedStyleBaseConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in ComputedStyleBase and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
ComputedStyleBase and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043
==========

to

==========
Add a generated ComputedStyleBase class that ComputedStyle extends

Add a generated ComputedStyleBase class that ComputedStyle extends from,
as well as a generated ComputedStyleBaseConstants file that
ComputedStyleConstants includes. Moved the 'visibility' field to be
generated in ComputedStyleBase and it's type, the EVisibility enum, to
be generated as well.

This patch adds the 'keyword_only' field to CSSProperties.in, which is
used to detect keyword-only properties that can be stored as bitfields,
as well as enough generation code to generate enum bitfields. Other
field types, as well as support for custom storage and methods, will be
added in future patches.

This is the beginning of an effort to move properties across to
ComputedStyleBase and then, eventually, remove ComputedStyle and rename
the base to ComputedStyle.

Design doc:
https://docs.google.com/document/d/1sWf_kCtVSokx8oDJZwTrUk2JNqrgTZDV0Z-jsy6tW...

BUG=628043

Committed: https://crrev.com/8439075a9356236aa3f893f67f23faab867baccf
Cr-Commit-Position: refs/heads/master@{#420508}
==========

[commit-bot: I haz the power, 2016-09-22 23:56:53]

Patchset 14 (id:??) landed as
https://crrev.com/8439075a9356236aa3f893f67f23faab867baccf
Cr-Commit-Position: refs/heads/master@{#420508}

[sashab, 2016-09-23 00:10:23]

Fyi esprehn; there was a memory leak caused by ComputedStyleBase not having a
virtual destructor and inheriting from RefCounted<>.
RefCounted<ComputedStyleBase> was calling ~ComputedStyleBase which doesn't call
~ComputedStyle. The LSAN bot caught this and I fixed it by leaving RefCounted<>
as a parent of ComputedStyle.

When we're all done with ComputedStyleBase I'll move RefCounted<> to the new
ComputedStyle :)