Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2354843002: Changed EFloat to an enum class (Closed)

Created:
4 years, 3 months ago by sashab
Modified:
4 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed EFloat to an enum class Changed EFloat to an enum class and gave it an unsigned underlying type. This is pre-work to move it to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/333a7dd429e44a6562112fc29c667474fa2e92f9 Cr-Commit-Position: refs/heads/master@{#420536}

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 24 (15 generated)
sashab
This patch is entirely find and replace, except the stuff in ComputedStyleConstants.h and the single ...
4 years, 3 months ago (2016-09-20 06:39:46 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 3 months ago (2016-09-20 07:00:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354843002/20001
4 years, 3 months ago (2016-09-23 00:27:29 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/265258)
4 years, 3 months ago (2016-09-23 00:36:31 UTC) #16
sashab
dstockwell@ for OWNERS; rs please :)
4 years, 3 months ago (2016-09-23 01:02:51 UTC) #18
dstockwell
lgtm
4 years, 3 months ago (2016-09-23 01:34:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354843002/20001
4 years, 3 months ago (2016-09-23 01:36:01 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 01:42:06 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 01:44:51 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/333a7dd429e44a6562112fc29c667474fa2e92f9
Cr-Commit-Position: refs/heads/master@{#420536}

Powered by Google App Engine
This is Rietveld 408576698