Issue 2312823002: Added support for isInherited flags to ComputedStyleBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2312823002: Added support for isInherited flags to ComputedStyleBase (Closed)

Created:
4 years, 3 months ago by sashab

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Added support for isInherited flags to ComputedStyleBase Added support for isInherited flags to ComputedStyleBase, and moved visibilityIsInherited to ComputedStyleBase. BUG=628043

Patch Set 1 #

Patch Set 2 : Rebase and a bit more cleanup work... Maybe needs a rethink #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -24 lines)			Patch
M	third_party/WebKit/Source/build/scripts/make_computed_style_base.py	View	1	4 chunks	+50 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl	View	1	1 chunk	+16 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl	View	1	8 chunks	+21 lines, -12 lines	0 comments	Download
M	third_party/WebKit/Source/core/style/ComputedStyle.h	View	1	3 chunks	+0 lines, -6 lines	0 comments	Download
M	third_party/WebKit/Source/core/style/ComputedStyle.cpp	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 2187493004 Patch 200001

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sashab

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

4 years, 3 months ago (2016-09-06 04:23:24 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312823002/1

4 years, 3 months ago (2016-09-06 04:23:38 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-09-06 04:34:35 UTC) #3

commit-bot: I haz the power

4 years, 3 months ago (2016-09-06 04:34:39 UTC) #4

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages