third_party/WebKit/Source/core/BUILD.gn - Issue 2187493004: Add a generated ComputedStyleBase class that ComputedStyle extends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2187493004: Add a generated ComputedStyleBase class that ComputedStyle extends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_make_visibility_enum_class_rebase

Patch Set: Re-ordered inheritance to match initializers Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/ComputedStyleBaseConstants.h.tmpl ('k') | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/BUILD.gn

diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn

index 51a4b50300c8c9ce9cf9f45e77f18b499f2a81ae..bcff57da3d1bed08de9443e2924ba6f265aad5e8 100644

--- a/third_party/WebKit/Source/core/BUILD.gn

+++ b/third_party/WebKit/Source/core/BUILD.gn

@@ -373,6 +373,20 @@ action("generated_testing_idls_internal_runtime_flags") {

]

}

+css_properties("make_core_generated_computed_style_base") {

+ script = "../build/scripts/make_computed_style_base.py"

+ other_inputs = [

+ "../build/scripts/templates/ComputedStyleBase.cpp.tmpl",

+ "../build/scripts/templates/ComputedStyleBase.h.tmpl",

+ "../build/scripts/templates/ComputedStyleBaseConstants.h.tmpl",

+ ]

+ outputs = [

+ "$blink_core_output_dir/ComputedStyleBase.cpp",

+ "$blink_core_output_dir/ComputedStyleBase.h",

+ "$blink_core_output_dir/ComputedStyleBaseConstants.h",

+ ]

css_properties("make_core_generated_css_property_names") {

script = "../build/scripts/make_css_property_names.py"

outputs = [

@@ -811,6 +825,7 @@ target(core_link_small_target_type, "core_generated") {

":make_core_generated_bison",

":make_core_generated_css_primitive_value_unit_trie",

":make_core_generated_css_property_metadata",

+ ":make_core_generated_computed_style_base",

":make_core_generated_css_property_names",

":make_core_generated_cssom_types",

":make_core_generated_event_factory",