Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Issue 2186633002: Remove all usage of SkSurfaceProps::isGammaCorrect() (Closed)

Created:
4 years, 4 months ago by Brian Osman
Modified:
4 years, 4 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove all usage of SkSurfaceProps::isGammaCorrect() DrawContext's isGammaCorrect now just based on presence of color space. Next change will remove the function and flag entirely, but I wanted to land this separately. This alters a few GMs in srgb/f16 mode, generally those that are creating off-screen surfaces in ways that were somewhat lossy before. No unexplained changes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186633002 Committed: https://skia.googlesource.com/skia/+/9dc935fa11521d4a6c7875699c050044a45d0871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -17 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 5 chunks +4 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
Brian Osman
4 years, 4 months ago (2016-07-26 16:50:44 UTC) #5
mtklein
unfamiliar with the code, but lgtm
4 years, 4 months ago (2016-07-26 17:17:20 UTC) #8
bsalomon
lgtm
4 years, 4 months ago (2016-07-26 17:18:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186633002/1
4 years, 4 months ago (2016-07-26 17:21:01 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 17:21:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9dc935fa11521d4a6c7875699c050044a45d0871

Powered by Google App Engine
This is Rietveld 408576698