Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2188463002: Remove SkSurfaceProps gamma-correctness flag entirely. (Closed)

Created:
4 years, 4 months ago by Brian Osman
Modified:
4 years, 4 months ago
Reviewers:
bsalomon, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@remove-is-gamma-correct
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkSurfaceProps gamma-correctness flag entirely. This is no longer required - gamma-correctness is now just based on the presence or absence of a color space. Public API change is just removal of (unused) flag. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2188463002 TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/3a0dbde1cfa84b08c7dd5b597142e9f6179f2d07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -80 lines) Patch
M dm/DMGpuSupport.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/dftext.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/surface.cpp View 4 chunks +2 lines, -8 lines 0 comments Download
M gm/textblobgeometrychange.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/textblobmixedsizes.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M gm/textblobrandomfont.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M include/core/SkSurfaceProps.h View 2 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/views/SkWindow.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/SRGBMipMapTest.cpp View 1 chunk +2 lines, -11 lines 0 comments Download
M tools/skiaserve/Request.cpp View 3 chunks +5 lines, -11 lines 0 comments Download
M tools/viewer/sk_app/WindowContext.cpp View 2 chunks +3 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
Brian Osman
4 years, 4 months ago (2016-07-26 17:23:14 UTC) #5
mtklein
lgtm
4 years, 4 months ago (2016-07-26 17:30:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188463002/1
4 years, 4 months ago (2016-07-26 17:43:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/11719)
4 years, 4 months ago (2016-07-26 17:45:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2188463002/1
4 years, 4 months ago (2016-07-26 18:35:06 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 18:36:09 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3a0dbde1cfa84b08c7dd5b597142e9f6179f2d07

Powered by Google App Engine
This is Rietveld 408576698