Permissions: Rename PermissionBubbleView to PermissionPromptInterface

Permissions: Rename PermissionBubbleView to PermissionPrompt

Also makes the following related renames:
  PermissionBubbleViewViews   -> PermissionPromptImpl
  MockPermissionBubbleView    -> MockPermissionPrompt
  MockPermissionBubbleFactory -> MockPermissionPromptFactory
  permission_bubble_view_views.cc       -> permission_prompt_impl_views.cc
  permission_bubble_view_cocoa_views.mm -> permission_prompt_impl_views_mac.mm

The result is a more consistent naming scheme across Views, Views on
Mac, and Cocoa on Mac, and is a step towards using
PermissionRequestManager and PermissionPrompt on Android.

BUG=606138
Committed: https://crrev.com/bba1b05906679e2ada6b0833c34dc9f3d345a446
Cr-Commit-Position: refs/heads/master@{#409380}

[tsergeant, 2016-07-26 04:35:32]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 04:35:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-07-26 04:44:50]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 04:45:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 04:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 04:56:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[tsergeant, 2016-07-26 06:28:51]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 06:29:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 08:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 08:05:11]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-07-27 05:02:31]

Description was changed from

==========
Permissions: Rename PermissionBubbleView to PermissionPromptInterface

Also makes the following related renames:
  PermissionBubbleViewViews   -> PermissionPrompt
  MockPermissionBubbleView    -> MockPermissionPrompt
  MockPermissionBubbleFactory -> MockPermissionRequestFactory

The result is a more consistent naming scheme across Views, Views on
Mac, and Cocoa on Mac, and is a step towards using
PermissionRequestManager and PermissionPrompt on Android.

BUG=606138
==========

to

==========
Permissions: Rename PermissionBubbleView to PermissionPromptInterface

Also makes the following related renames:
  PermissionBubbleViewViews   -> PermissionPrompt
  MockPermissionBubbleView    -> MockPermissionPrompt
  MockPermissionBubbleFactory -> MockPermissionRequestFactory
  permission_bubble_view_views.cc       -> permission_prompt_views.cc
  permission_bubble_view_cocoa_views.mm -> permission_prompt_views_mac.mm

The result is a more consistent naming scheme across Views, Views on
Mac, and Cocoa on Mac, and is a step towards using
PermissionRequestManager and PermissionPrompt on Android.

BUG=606138
==========

[tsergeant, 2016-07-27 05:02:52]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2016-07-27 05:03:03]

Patchset #2 (id:40001) has been deleted

[tsergeant, 2016-07-27 05:42:46]

tsergeant@chromium.org changed reviewers:
+ raymes@chromium.org

[tsergeant, 2016-07-27 05:42:47]

Raymes, PTAL.

The names I ended up using are a little different to what I circulated in the
design doc last week. Let me know if you see any issues with them~.

[raymes, 2016-07-28 04:55:01]

I think MockPermissionRequestFactory should possibly be
MockPermissionPromptFactory

Also, perhaps consider using:
PermissionPrompt (rather than PermissionPromptInterface) and
PermissionPromptImpl or PermissionPromptViews (if it's views specific).

[tsergeant, 2016-07-29 03:35:14]

Description was changed from

==========
Permissions: Rename PermissionBubbleView to PermissionPromptInterface

Also makes the following related renames:
  PermissionBubbleViewViews   -> PermissionPrompt
  MockPermissionBubbleView    -> MockPermissionPrompt
  MockPermissionBubbleFactory -> MockPermissionRequestFactory
  permission_bubble_view_views.cc       -> permission_prompt_views.cc
  permission_bubble_view_cocoa_views.mm -> permission_prompt_views_mac.mm

The result is a more consistent naming scheme across Views, Views on
Mac, and Cocoa on Mac, and is a step towards using
PermissionRequestManager and PermissionPrompt on Android.

BUG=606138
==========

to

==========
Permissions: Rename PermissionBubbleView to PermissionPrompt

Also makes the following related renames:
  PermissionBubbleViewViews   -> PermissionPromptImpl
  MockPermissionBubbleView    -> MockPermissionPrompt
  MockPermissionBubbleFactory -> MockPermissionPromptFactory
  permission_bubble_view_views.cc       -> permission_prompt_impl_views.cc
  permission_bubble_view_cocoa_views.mm -> permission_prompt_impl_views_mac.mm

The result is a more consistent naming scheme across Views, Views on
Mac, and Cocoa on Mac, and is a step towards using
PermissionRequestManager and PermissionPrompt on Android.

BUG=606138
==========

[tsergeant, 2016-07-29 03:35:31]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 03:35:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 04:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 04:26:41]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-07-29 04:55:38]

On 2016/07/28 04:55:01, raymes wrote:
> I think MockPermissionRequestFactory should possibly be
> MockPermissionPromptFactory
> 
> Also, perhaps consider using:
> PermissionPrompt (rather than PermissionPromptInterface) and
> PermissionPromptImpl or PermissionPromptViews (if it's views specific).

I've updated the names, as we discussed. PTAL.

[raymes, 2016-08-01 00:58:13]

lgtm

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/download...
File chrome/browser/download/download_request_limiter_unittest.cc (right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/download...
chrome/browser/download/download_request_limiter_unittest.cc:102:
mock_permission_request_factory_.reset(new MockPermissionPromptFactory(
prompt_factory (here and below)

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/geolocat...
File chrome/browser/geolocation/geolocation_permission_context_unittest.cc
(right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/geolocat...
chrome/browser/geolocation/geolocation_permission_context_unittest.cc:172:
mock_permission_request_factories_;
prompt_factories_

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/permissi...
File chrome/browser/permissions/permission_request_manager_browsertest.cc
(right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/permissi...
chrome/browser/permissions/permission_request_manager_browsertest.cc:39:
mock_permission_request_factory_.reset(
prompt

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/permissi...
File chrome/browser/permissions/permission_request_manager_unittest.cc (right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/permissi...
chrome/browser/permissions/permission_request_manager_unittest.cc:94:
std::unique_ptr<MockPermissionPromptFactory> view_factory_;
prompt_factory

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:86:
MockPermissionPromptFactory* bubble_factory() {
prompt_factory

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:87: return
mock_permission_bubble_factory_.get();
prompt_factory

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc
(right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:36:
MockPermissionPrompt* view =
prompt

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.h
(right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.h:67:
std::vector<MockPermissionPrompt*> views_;
prompts_?

[tsergeant, 2016-08-01 02:48:26]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 02:48:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 03:33:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 03:33:31]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-08-01 23:41:11]

tsergeant@chromium.org changed reviewers:
+ tapted@chromium.org

[tsergeant, 2016-08-01 23:41:13]

+tapted@ for c/b/ui/cocoa

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/download...
File chrome/browser/download/download_request_limiter_unittest.cc (right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/download...
chrome/browser/download/download_request_limiter_unittest.cc:102:
mock_permission_request_factory_.reset(new MockPermissionPromptFactory(
On 2016/08/01 00:58:13, raymes wrote:
> prompt_factory (here and below)

Done.

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/geolocat...
File chrome/browser/geolocation/geolocation_permission_context_unittest.cc
(right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/geolocat...
chrome/browser/geolocation/geolocation_permission_context_unittest.cc:172:
mock_permission_request_factories_;
On 2016/08/01 00:58:13, raymes wrote:
> prompt_factories_

Done.

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/permissi...
File chrome/browser/permissions/permission_request_manager_browsertest.cc
(right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/permissi...
chrome/browser/permissions/permission_request_manager_browsertest.cc:39:
mock_permission_request_factory_.reset(
On 2016/08/01 00:58:13, raymes wrote:
> prompt

Done.

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/permissi...
File chrome/browser/permissions/permission_request_manager_unittest.cc (right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/permissi...
chrome/browser/permissions/permission_request_manager_unittest.cc:94:
std::unique_ptr<MockPermissionPromptFactory> view_factory_;
On 2016/08/01 00:58:13, raymes wrote:
> prompt_factory

Done.

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:86:
MockPermissionPromptFactory* bubble_factory() {
On 2016/08/01 00:58:13, raymes wrote:
> prompt_factory

Done.

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:87: return
mock_permission_bubble_factory_.get();
On 2016/08/01 00:58:13, raymes wrote:
> prompt_factory

Done.

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc
(right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:36:
MockPermissionPrompt* view =
On 2016/08/01 00:58:13, raymes wrote:
> prompt

Done.

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.h
(right):

https://codereview.chromium.org/2182883002/diff/80001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.h:67:
std::vector<MockPermissionPrompt*> views_;
On 2016/08/01 00:58:13, raymes wrote:
> prompts_?

Done.

[tapted, 2016-08-02 02:43:36]

c/b/ui/cocoa/ lgtm

[tsergeant, 2016-08-02 02:53:06]

tsergeant@chromium.org changed reviewers:
+ thestig@chromium.org

[tsergeant, 2016-08-02 02:53:07]

Thanks!

+thestig@ for the remaining bits and pieces

[Lei Zhang, 2016-08-02 03:59:22]

lgtm

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/downloa...
File chrome/browser/download/download_request_limiter_unittest.cc (right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/downloa...
chrome/browser/download/download_request_limiter_unittest.cc:121:
mock_permission_prompt_factory_->set_response_type(
Use a switch statement to calculate an AutoResponseType value and call
set_response_type() in just 1 place?

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:49: new
MockPermissionPromptFactory(manager));
BTW, this can just be: foo = base::MakeUnique<Foo>(args);

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc
(right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:28: while
(!prompts_.empty()) {
Can this just iterate in reverse, set |factory_| to nullptr for each prompt, and
then clear() |prompts_| ?

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:87: for
(std::vector<MockPermissionPrompt*>::iterator iter = prompts_.begin();
if (ContainsValue(prompts_, prompt))
  return;

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:99: for
(std::vector<MockPermissionPrompt*>::iterator iter = prompts_.begin();
auto it = std::find(prompts_.begin(), prompts_.end(), prompt);
if (it != prompts_.end())
  prompts_.erase(it);

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.h
(right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.h:15: class
MockPermissionPrompt;
alphabetical order

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/permission_prompt.h (right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/permission_prompt.h:42: // Sets the delegate
which will receive UI events forwarded from the bubble.
Do you care about the remaining references to bubbles?

[tsergeant, 2016-08-02 07:01:54]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 07:02:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 07:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 07:22:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tsergeant, 2016-08-02 07:35:34]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 07:35:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-08-02 07:54:24]

Patchset #5 (id:120001) has been deleted

[tsergeant, 2016-08-02 08:05:16]

thestig: There's one question below

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/downloa...
File chrome/browser/download/download_request_limiter_unittest.cc (right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/downloa...
chrome/browser/download/download_request_limiter_unittest.cc:121:
mock_permission_prompt_factory_->set_response_type(
On 2016/08/02 03:59:22, Lei Zhang wrote:
> Use a switch statement to calculate an AutoResponseType value and call
> set_response_type() in just 1 place?

Done.

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/safe_br...
File chrome/browser/safe_browsing/permission_reporter_browsertest.cc (right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/safe_br...
chrome/browser/safe_browsing/permission_reporter_browsertest.cc:49: new
MockPermissionPromptFactory(manager));
On 2016/08/02 03:59:22, Lei Zhang wrote:
> BTW, this can just be: foo = base::MakeUnique<Foo>(args);

Done.

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc
(right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:28: while
(!prompts_.empty()) {
On 2016/08/02 03:59:22, Lei Zhang wrote:
> Can this just iterate in reverse, set |factory_| to nullptr for each prompt,
and
> then clear() |prompts_| ?

Is there any particular relevance to going in reverse? I've uploaded a version
that iterates forwards through the array which seems to work fine.

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:87: for
(std::vector<MockPermissionPrompt*>::iterator iter = prompts_.begin();
On 2016/08/02 03:59:22, Lei Zhang wrote:
> if (ContainsValue(prompts_, prompt))
>   return;

Done.

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:99: for
(std::vector<MockPermissionPrompt*>::iterator iter = prompts_.begin();
On 2016/08/02 03:59:22, Lei Zhang wrote:
> auto it = std::find(prompts_.begin(), prompts_.end(), prompt);
> if (it != prompts_.end())
>   prompts_.erase(it);

Done.

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.h
(right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.h:15: class
MockPermissionPrompt;
On 2016/08/02 03:59:22, Lei Zhang wrote:
> alphabetical order

Done.

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/permission_prompt.h (right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/permission_prompt.h:42: // Sets the delegate
which will receive UI events forwarded from the bubble.
On 2016/08/02 03:59:22, Lei Zhang wrote:
> Do you care about the remaining references to bubbles?

I've been renaming most of them, yeah. Done.

[Lei Zhang, 2016-08-02 08:21:16]

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc
(right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:28: while
(!prompts_.empty()) {
On 2016/08/02 08:05:16, tsergeant wrote:
> On 2016/08/02 03:59:22, Lei Zhang wrote:
> > Can this just iterate in reverse, set |factory_| to nullptr for each prompt,
> and
> > then clear() |prompts_| ?
> 
> Is there any particular relevance to going in reverse? I've uploaded a version
> that iterates forwards through the array which seems to work fine.

The code is currently going in reverse. Wasn't sure if that was important or
not, or if it is being done simply because pop_front() on a vector is
inefficient. Forward is fine if that works.

[commit-bot: I haz the power, 2016-08-02 08:31:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 08:31:19]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-08-02 23:28:11]

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
File chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc
(right):

https://codereview.chromium.org/2182883002/diff/100001/chrome/browser/ui/webs...
chrome/browser/ui/website_settings/mock_permission_prompt_factory.cc:28: while
(!prompts_.empty()) {
On 2016/08/02 08:21:16, Lei Zhang wrote:
> On 2016/08/02 08:05:16, tsergeant wrote:
> > On 2016/08/02 03:59:22, Lei Zhang wrote:
> > > Can this just iterate in reverse, set |factory_| to nullptr for each
prompt,
> > and
> > > then clear() |prompts_| ?
> > 
> > Is there any particular relevance to going in reverse? I've uploaded a
version
> > that iterates forwards through the array which seems to work fine.
> 
> The code is currently going in reverse. Wasn't sure if that was important or
> not, or if it is being done simply because pop_front() on a vector is
> inefficient. Forward is fine if that works.

Yeah, I don't think there's any reason other than efficiency for the current
code to be in reverse.

[tsergeant, 2016-08-02 23:28:19]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-08-02 23:28:20]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org,
thestig@chromium.org, tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2182883002/#ps140001
(title: "thestig@ review")

[commit-bot: I haz the power, 2016-08-02 23:29:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-08-02 23:31:08]

On 2016/08/02 23:28:11, tsergeant wrote:
> Yeah, I don't think there's any reason other than efficiency for the current
> code to be in reverse.

Thanks!

[commit-bot: I haz the power, 2016-08-02 23:34:26]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2016-08-02 23:36:45]

Description was changed from

==========
Permissions: Rename PermissionBubbleView to PermissionPrompt

Also makes the following related renames:
  PermissionBubbleViewViews   -> PermissionPromptImpl
  MockPermissionBubbleView    -> MockPermissionPrompt
  MockPermissionBubbleFactory -> MockPermissionPromptFactory
  permission_bubble_view_views.cc       -> permission_prompt_impl_views.cc
  permission_bubble_view_cocoa_views.mm -> permission_prompt_impl_views_mac.mm

The result is a more consistent naming scheme across Views, Views on
Mac, and Cocoa on Mac, and is a step towards using
PermissionRequestManager and PermissionPrompt on Android.

BUG=606138
==========

to

==========
Permissions: Rename PermissionBubbleView to PermissionPrompt

Also makes the following related renames:
  PermissionBubbleViewViews   -> PermissionPromptImpl
  MockPermissionBubbleView    -> MockPermissionPrompt
  MockPermissionBubbleFactory -> MockPermissionPromptFactory
  permission_bubble_view_views.cc       -> permission_prompt_impl_views.cc
  permission_bubble_view_cocoa_views.mm -> permission_prompt_impl_views_mac.mm

The result is a more consistent naming scheme across Views, Views on
Mac, and Cocoa on Mac, and is a step towards using
PermissionRequestManager and PermissionPrompt on Android.

BUG=606138

Committed: https://crrev.com/bba1b05906679e2ada6b0833c34dc9f3d345a446
Cr-Commit-Position: refs/heads/master@{#409380}
==========

[commit-bot: I haz the power, 2016-08-02 23:36:47]

Patchset 5 (id:??) landed as
https://crrev.com/bba1b05906679e2ada6b0833c34dc9f3d345a446
Cr-Commit-Position: refs/heads/master@{#409380}