Permissions: Rename PermissionBubbleView to PermissionPromptInterface

chrome/browser/permissions/permission_request_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/browser/permissions/mock_permission_request.h"
 #include "chrome/browser/permissions/permission_request.h"
 #include "chrome/browser/permissions/permission_request_manager.h"
 #include "chrome/browser/permissions/permission_uma_util.h"
-#include "chrome/browser/ui/website_settings/mock_permission_bubble_factory.h"
+#include "chrome/browser/ui/website_settings/mock_permission_prompt_factory.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness {
  public:
   PermissionRequestManagerTest()
       : ChromeRenderViewHostTestHarness(),
         request1_("test1",
                   PermissionRequestType::QUOTA,
                   PermissionRequestGestureType::GESTURE),
         request2_("test2",
                   PermissionRequestType::DOWNLOAD,
                   PermissionRequestGestureType::NO_GESTURE),
         iframe_request_same_domain_("iframe",
                                     GURL("http://www.google.com/some/url")),
         iframe_request_other_domain_("iframe", GURL("http://www.youtube.com")) {
   }
   ~PermissionRequestManagerTest() override {}
 
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
     SetContents(CreateTestWebContents());
     NavigateAndCommit(GURL("http://www.google.com"));
 
     manager_.reset(new PermissionRequestManager(web_contents()));
-    view_factory_.reset(new MockPermissionBubbleFactory(manager_.get()));
+    prompt_factory_.reset(new MockPermissionPromptFactory(manager_.get()));
   }
 
   void TearDown() override {
-    view_factory_.reset();
+    prompt_factory_.reset();
     manager_.reset();
     ChromeRenderViewHostTestHarness::TearDown();
   }
 
   void ToggleAccept(int index, bool value) {
     manager_->ToggleAccept(index, value);
   }
 
   void Accept() {
     manager_->Accept();
@@ skipping 26 matching lines @@
       const content::LoadCommittedDetails& details) {
     manager_->NavigationEntryCommitted(details);
   }
 
  protected:
   MockPermissionRequest request1_;
   MockPermissionRequest request2_;
   MockPermissionRequest iframe_request_same_domain_;
   MockPermissionRequest iframe_request_other_domain_;
   std::unique_ptr<PermissionRequestManager> manager_;
-  std::unique_ptr<MockPermissionBubbleFactory> view_factory_;
+  std::unique_ptr<MockPermissionPromptFactory> prompt_factory_;
 };
 
 TEST_F(PermissionRequestManagerTest, SingleRequest) {
   manager_->AddRequest(&request1_);
   manager_->DisplayPendingRequests();
   WaitForCoalescing();
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
 
   ToggleAccept(0, true);
   Accept();
   EXPECT_TRUE(request1_.granted());
 }
 
 TEST_F(PermissionRequestManagerTest, SingleRequestViewFirst) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
 
   ToggleAccept(0, true);
   Accept();
   EXPECT_TRUE(request1_.granted());
 }
 
 TEST_F(PermissionRequestManagerTest, TwoRequests) {
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&request2_);
   manager_->DisplayPendingRequests();
   WaitForCoalescing();
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 2);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 2);
 
   ToggleAccept(0, true);
   ToggleAccept(1, false);
   Accept();
   EXPECT_TRUE(request1_.granted());
   EXPECT_FALSE(request2_.granted());
 }
 
 TEST_F(PermissionRequestManagerTest, TwoRequestsTabSwitch) {
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&request2_);
   manager_->DisplayPendingRequests();
   WaitForCoalescing();
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 2);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 2);
 
   ToggleAccept(0, true);
   ToggleAccept(1, false);
 
   MockTabSwitchAway();
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
 
   MockTabSwitchBack();
   WaitForCoalescing();
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 2);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 2);
 
   Accept();
   EXPECT_TRUE(request1_.granted());
   EXPECT_FALSE(request2_.granted());
 }
 
 TEST_F(PermissionRequestManagerTest, NoRequests) {
   manager_->DisplayPendingRequests();
   WaitForCoalescing();
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
 }
 
 TEST_F(PermissionRequestManagerTest, NoView) {
   manager_->AddRequest(&request1_);
   // Don't display the pending requests.
   WaitForCoalescing();
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
 }
 
 TEST_F(PermissionRequestManagerTest, TwoRequestsCoalesce) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&request2_);
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
   WaitForCoalescing();
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 2);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 2);
 }
 
 TEST_F(PermissionRequestManagerTest, TwoRequestsDoNotCoalesce) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
   manager_->AddRequest(&request2_);
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
 }
 
 TEST_F(PermissionRequestManagerTest, TwoRequestsShownInTwoBubbles) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
   manager_->AddRequest(&request2_);
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
 
   Accept();
   WaitForCoalescing();
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
-  ASSERT_EQ(view_factory_->show_count(), 2);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
+  ASSERT_EQ(prompt_factory_->show_count(), 2);
 }
 
 TEST_F(PermissionRequestManagerTest, TestAddDuplicateRequest) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&request2_);
   manager_->AddRequest(&request1_);
 
   WaitForCoalescing();
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 2);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 2);
 }
 
 TEST_F(PermissionRequestManagerTest, SequentialRequests) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
 
   Accept();
   EXPECT_TRUE(request1_.granted());
 
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
 
   manager_->AddRequest(&request2_);
   WaitForCoalescing();
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
   Accept();
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
   EXPECT_TRUE(request2_.granted());
 }
 
 TEST_F(PermissionRequestManagerTest, SameRequestRejected) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&request1_);
   EXPECT_FALSE(request1_.finished());
 
   WaitForCoalescing();
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
 }
 
 TEST_F(PermissionRequestManagerTest, DuplicateRequestCancelled) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   MockPermissionRequest dupe_request("test1");
   manager_->AddRequest(&dupe_request);
   EXPECT_FALSE(dupe_request.finished());
   EXPECT_FALSE(request1_.finished());
   manager_->CancelRequest(&request1_);
@@ skipping 26 matching lines @@
   EXPECT_TRUE(request2_.finished());
 }
 
 TEST_F(PermissionRequestManagerTest, ForgetRequestsOnPageNavigation) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
   manager_->AddRequest(&request2_);
   manager_->AddRequest(&iframe_request_other_domain_);
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
 
   NavigateAndCommit(GURL("http://www2.google.com/"));
   WaitForCoalescing();
 
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
   EXPECT_TRUE(request1_.finished());
   EXPECT_TRUE(request2_.finished());
   EXPECT_TRUE(iframe_request_other_domain_.finished());
 }
 
 TEST_F(PermissionRequestManagerTest, TestCancelQueued) {
   manager_->AddRequest(&request1_);
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
 
   manager_->CancelRequest(&request1_);
   EXPECT_TRUE(request1_.finished());
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
   manager_->DisplayPendingRequests();
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
 
   manager_->AddRequest(&request2_);
   WaitForCoalescing();
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
 }
 
 TEST_F(PermissionRequestManagerTest, TestCancelWhileDialogShown) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
 
-  view_factory_->SetCanUpdateUi(true);
-  EXPECT_TRUE(view_factory_->is_visible());
+  prompt_factory_->SetCanUpdateUi(true);
+  EXPECT_TRUE(prompt_factory_->is_visible());
   EXPECT_FALSE(request1_.finished());
   manager_->CancelRequest(&request1_);
   WaitForCoalescing();
   EXPECT_TRUE(request1_.finished());
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
 }
 
 TEST_F(PermissionRequestManagerTest, TestCancelWhileDialogShownNoUpdate) {
   manager_->DisplayPendingRequests();
-  view_factory_->SetCanUpdateUi(false);
+  prompt_factory_->SetCanUpdateUi(false);
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
-  view_factory_->SetCanUpdateUi(false);
+  prompt_factory_->SetCanUpdateUi(false);
 
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
   EXPECT_FALSE(request1_.finished());
   manager_->CancelRequest(&request1_);
   EXPECT_TRUE(request1_.finished());
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
   Closing();
 }
 
 TEST_F(PermissionRequestManagerTest, TestCancelPendingRequest) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
   manager_->AddRequest(&request2_);
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
   manager_->CancelRequest(&request2_);
 
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
   EXPECT_FALSE(request1_.finished());
   EXPECT_TRUE(request2_.finished());
 }
 
 TEST_F(PermissionRequestManagerTest, MainFrameNoRequestIFrameRequest) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&iframe_request_same_domain_);
   WaitForCoalescing();
   WaitForFrameLoad();
 
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
   Closing();
   EXPECT_TRUE(iframe_request_same_domain_.finished());
 }
 
 TEST_F(PermissionRequestManagerTest, MainFrameAndIFrameRequestSameDomain) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&iframe_request_same_domain_);
   WaitForFrameLoad();
   WaitForCoalescing();
 
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 2);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 2);
   Closing();
   EXPECT_TRUE(request1_.finished());
   EXPECT_TRUE(iframe_request_same_domain_.finished());
-  EXPECT_FALSE(view_factory_->is_visible());
+  EXPECT_FALSE(prompt_factory_->is_visible());
 }
 
 TEST_F(PermissionRequestManagerTest, MainFrameAndIFrameRequestOtherDomain) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&iframe_request_other_domain_);
   WaitForFrameLoad();
   WaitForCoalescing();
 
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
   Closing();
   EXPECT_TRUE(request1_.finished());
   EXPECT_FALSE(iframe_request_other_domain_.finished());
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
   Closing();
   EXPECT_TRUE(iframe_request_other_domain_.finished());
 }
 
 TEST_F(PermissionRequestManagerTest, IFrameRequestWhenMainRequestVisible) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
 
   manager_->AddRequest(&iframe_request_same_domain_);
   WaitForFrameLoad();
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
   Closing();
   EXPECT_TRUE(request1_.finished());
   EXPECT_FALSE(iframe_request_same_domain_.finished());
-  EXPECT_TRUE(view_factory_->is_visible());
-  ASSERT_EQ(view_factory_->request_count(), 1);
+  EXPECT_TRUE(prompt_factory_->is_visible());
+  ASSERT_EQ(prompt_factory_->request_count(), 1);
   Closing();
   EXPECT_TRUE(iframe_request_same_domain_.finished());
 }
 
 TEST_F(PermissionRequestManagerTest,
        IFrameRequestOtherDomainWhenMainRequestVisible) {
   manager_->DisplayPendingRequests();
   manager_->AddRequest(&request1_);
   WaitForCoalescing();
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
 
   manager_->AddRequest(&iframe_request_other_domain_);
   WaitForFrameLoad();
   Closing();
   EXPECT_TRUE(request1_.finished());
   EXPECT_FALSE(iframe_request_other_domain_.finished());
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
   Closing();
   EXPECT_TRUE(iframe_request_other_domain_.finished());
 }
 
 TEST_F(PermissionRequestManagerTest, RequestsDontNeedUserGesture) {
   manager_->DisplayPendingRequests();
   WaitForFrameLoad();
   WaitForCoalescing();
   manager_->AddRequest(&request1_);
   manager_->AddRequest(&iframe_request_other_domain_);
   manager_->AddRequest(&request2_);
   base::RunLoop().RunUntilIdle();
 
-  EXPECT_TRUE(view_factory_->is_visible());
+  EXPECT_TRUE(prompt_factory_->is_visible());
 }
 
 TEST_F(PermissionRequestManagerTest, UMAForSimpleAcceptedGestureBubble) {
   base::HistogramTester histograms;
 
   manager_->AddRequest(&request1_);
   manager_->DisplayPendingRequests();
   WaitForCoalescing();
   histograms.ExpectUniqueSample(
       PermissionUmaUtil::kPermissionsPromptShown,
@@ skipping 170 matching lines @@
       1);
   histograms.ExpectBucketCount(
       PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::QUOTA),
       1);
   histograms.ExpectBucketCount(
       PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied,
       static_cast<base::HistogramBase::Sample>(PermissionRequestType::DOWNLOAD),
       1);
 }